-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Copilot improvements #3455
Conversation
# Conflicts: # articles/tools/copilot/index.adoc
Co-authored-by: Knoobie <Knoobie@gmx.de>
articles/tools/copilot/index.adoc
Outdated
|
||
To get the best Copilot experience use the Vaadin plugin for link:https://plugins.jetbrains.com/plugin/23758-vaadin[IntelliJ] or link:https://marketplace.visualstudio.com/items?itemName=vaadin.vaadin-vscode[Visual Studio Code]. It improves saving changes you made into your files, enables seamless Undo integration (IntelliJ only) and more! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does and more
refer to? This isn't a marketing page, where we should build up “hype”. Stick to what we know our products do and don't do, and don't leave readers guessing. Also, avoid getting excited in documentation (avoid exclamation marks).
I don't fully understand what improves saving changes you made into your files
means. What does “saving changes you made into your files” mean more concretely, and how does Copilot improve that?
To get the best Copilot experience use the Vaadin plugin for link:https://plugins.jetbrains.com/plugin/23758-vaadin[IntelliJ] or link:https://marketplace.visualstudio.com/items?itemName=vaadin.vaadin-vscode[Visual Studio Code]. It improves saving changes you made into your files, enables seamless Undo integration (IntelliJ only) and more! | |
To get the best Copilot experience, use the Vaadin plugin for link:https://plugins.jetbrains.com/plugin/23758-vaadin[IntelliJ] or link:https://marketplace.visualstudio.com/items?itemName=vaadin.vaadin-vscode[Visual Studio Code]. The plugin improves saving changes you made into your files and integrates with the undo-functionality (IntelliJ only). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improves saving changes you made into your files
It was suppose to mean that if you use plugin, IDE document is automatically refreshed. Without it user must rely on IDE's file system watcher and sometimes changes might be unnoticed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, so when I edit a view with Copilot, the plugin makes sure the source code file, if opened in the IDE, shows the updated code as well. I think we should explain it like that instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Fixes #1573