Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vaadin/typescript-requiring-type-checking #36

Merged
merged 13 commits into from
Feb 2, 2023
Merged

feat: add vaadin/typescript-requiring-type-checking #36

merged 13 commits into from
Feb 2, 2023

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jan 31, 2023 •
edited
Loading

Description

The PR extracts TypeScript rules requiring type information into an opt-in config named respectively vaadin/typescript-requiring-type-checking. The reason is that these typed rules require TypeScript to build the whole project before ESLint can do its linting which can affect linting performance significantly.

Type of change

  • Feature

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Lodin
Lodin requested changes Jan 31, 2023
View reviewed changes
typescript-requiring-type-checking.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Lodin
Lodin requested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@Lodin Lodin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you need to put the new file to exports in package.json

@vursen
Copy link
Contributor Author

vursen commented Jan 31, 2023

Also, you need to put the new file to exports in package.json

Done.

@vursen vursen requested a review from Lodin January 31, 2023 13:55
@vursen vursen force-pushed the extract-typescript-requiring-type-information branch from c057cc2 to 27368a8 Compare January 31, 2023 13:56
@Lodin
Copy link
Contributor

Lodin commented Jan 31, 2023

@vursen, the generated file is still in the PR. Could you remove it?

Lodin
Lodin requested changes Jan 31, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@vursen
Copy link
Contributor Author

vursen commented Jan 31, 2023 •
edited
Loading

@vursen, the generated file is still in the PR. Could you remove it?

My bad. Apparently, it got back in some of my following commits. Removed.

vursen
vursen commented Jan 31, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@vursen vursen force-pushed the extract-typescript-requiring-type-information branch from 3c14c05 to 4afd61e Compare January 31, 2023 15:03
@vursen vursen requested a review from Lodin February 2, 2023 07:33
@vursen vursen force-pushed the extract-typescript-requiring-type-information branch from ee07852 to 027ec0b Compare February 2, 2023 11:21
@vursen vursen merged commit 07bcc65 into main Feb 2, 2023
@vursen vursen deleted the extract-typescript-requiring-type-information branch February 2, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lodin Lodin Lodin approved these changes

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vursen @CLAassistant @Lodin @web-padawan