Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable space-in-parens rule #9

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Enable space-in-parens rule #9

merged 1 commit into from
Oct 2, 2017

Conversation

limonte
Copy link

@limonte limonte commented Oct 1, 2017

This rule is needed to prevent extra whitespaces in cases like this:

if (variable ) {
  //        ^
}

Noticed in vaadin/vaadin-upload#218 by @web-padawan


This change is Reviewable

@platosha
Copy link

platosha commented Oct 2, 2017

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@manolo
Copy link
Member

manolo commented Oct 2, 2017

Reviewed 1 of 1 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@manolo manolo merged commit fc15827 into master Oct 2, 2017
@manolo manolo deleted the space-in-parens branch October 2, 2017 10:27
@manolo manolo removed the in review label Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants