This repository has been archived by the owner on May 6, 2021. It is now read-only.
fix: improve the Quick Start and Migrating from Vaadin 14 pages #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly mention that the plugin version needs to be changed as well, so that the project uses matching versions of the Vaadin platform and the Vaadin Maven plugin. This addresses one of the comments from DX tests.
added 7 commits
December 27, 2019 15:37
This is needed after `pnpm` became the default front-end package manager in Vaadin apps (see vaadin/flow#6966)
- the `route.action` property does not allow returning a promise of a particular ES module, thus `action: () => import('./views/help/app-help')` does not pass the type check
- the `click()` method in the snippet overrides the `HTMLElement`'s `click` property, which is not intended
- add an import for the `vaadin-button` custom element used in the snippet
- into the 'upgrading from V14' guide
vlukashov
changed the title
platosha
approved these changes
Dec 27, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
platosha
deleted the
vl/fix-quick-upgrade-guide-mention-vaadin-maven-plugin
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading from Vaadin 14
Explicitly mention that the plugin version needs to be changed as well, so that the project uses matching versions of the Vaadin platform and the Vaadin Maven plugin.
This is needed after
pnpmbecame the default front-end package manager in Vaadin apps (see Use pnpm instead of npm for frontend resources flow#6966)pnpm installcommandQuick Start Guide
route.actionproperty does not allow returning a promise of a particular ES module, thusaction: () => import('./views/help/app-help')does not pass the type checkclick()method in the snippet overrides theHTMLElement'sclickproperty, which is not intendedvaadin-buttoncustom element used in a code snippetThis addresses comments from the recent DX tests.
This change is