fix: do not throw when min is set to negative infinity (#6246) (#6251)

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
vaadin · Apr 26, 2024 · e8ead46 · e8ead46
1 parent 46dcac2
commit e8ead46
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/...ext-field-flow/src/main/java/com/vaadin/flow/component/textfield/AbstractNumberField.java b/...ext-field-flow/src/main/java/com/vaadin/flow/component/textfield/AbstractNumberField.java
@@ -384,7 +384,9 @@ private boolean isValidByStep(T value) {
         // When min is not defined by user, its value is the absoluteMin
         // provided in constructor. In this case, min should not be considered
         // in the step validation.
-        double stepBasis = minSetByUser ? getMinDouble() : 0.0;
+        double stepBasis = minSetByUser && !Double.isInfinite(getMinDouble())
+                ? getMinDouble()
+                : 0.0;
 
         // (value - stepBasis) % step == 0
         return new BigDecimal(String.valueOf(value))

diff --git a/...t-field-flow/src/test/java/com/vaadin/flow/component/textfield/tests/NumberFieldTest.java b/...t-field-flow/src/test/java/com/vaadin/flow/component/textfield/tests/NumberFieldTest.java
@@ -190,6 +190,13 @@ public void stepValidation_negativeMin_minUsedAsStepBasis() {
         assertInvalidValues(-4.5, 0.0, 1.0, 4.5);
     }
 
+    @Test
+    public void setMinNegativeInfinity_doesNotThrow() {
+        field.setStep(1.0);
+        field.setMin(Double.NEGATIVE_INFINITY);
+        field.setValue(6.0);
+    }
+
     @Override
     @Test
     public void elementHasValue_wrapIntoTextField_propertyIsNotSetToInitialValue() {