Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make context menu clicks cover the whole cell #2458

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

sissbruecker
Copy link
Contributor

Description

Fixes the grid context menu to always provide the correct item information in the open event, as well as the dynamic content handler. Previously in both cases the item could be missing if the context click was not directly on the grid cell content element, but on the table cell element itself. The approach of using the sourceEvent to get the event context is taken from the Typescript example in the docs: https://vaadin.com/docs/latest/ds/components/grid/#context-menu

Fixes #2444

Type of change

  • Bugfix
  • Feature

@vaadin-bot
Copy link
Collaborator

Hi @sissbruecker and @sissbruecker, when i performed cherry-pick to this commit to 14.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 2606328
error: could not apply 2606328... fix: make context menu clicks cover the whole cell (#2458)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Item in GridContextMenu is null when opened outside cell component
3 participants