fix: make context menu clicks cover the whole cell #2458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the grid context menu to always provide the correct item information in the open event, as well as the dynamic content handler. Previously in both cases the item could be missing if the context click was not directly on the grid cell content element, but on the table cell element itself. The approach of using the
sourceEvent
to get the event context is taken from the Typescript example in the docs: https://vaadin.com/docs/latest/ds/components/grid/#context-menuFixes #2444
Type of change