fix: delegate sendKeys calls to the input element #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
fix/delegate-send-keys
branch
from
8db6fb2
to
7772628
Compare
vursen
requested review from
yuriy-fix,
web-padawan and
sissbruecker
and removed request for
web-padawan
web-padawan
approved these changes
Aug 11, 2022
yuriy-fix
approved these changes
Aug 11, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures
sendKeyscalls are delegated to the component's slotted input element as callingsendKeysdirectly on the component's host doesn't seem to be reliable.A follow-up to #3502
Related to #3515
Related to #3496
Type of change
Checklist