Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: put getDefaultValidator implementation behind a feature flag #3597

Merged
merged 14 commits into from
Aug 23, 2022
Merged

refactor!: put getDefaultValidator implementation behind a feature flag #3597

merged 14 commits into from
Aug 23, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Aug 15, 2022 •
edited
Loading

Description

The PR puts the getDefaultValidator implementation behind the feature flag forceFieldValidation as we agreed in vaadin/flow#14285 (comment).

  • DatePicker
  • TimePicker
  • DateTimePicker
  • IntegerField
  • NumberField
  • EmailField
  • TextArea

Part of vaadin/platform#3066

A follow-up to #3381

Type of change

  • Refactor

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen force-pushed the refactor/put-default-validator-behind-feature-flag branch from 8aba2e1 to 1008be9 Compare August 15, 2022 13:51
@vursen vursen marked this pull request as ready for review August 15, 2022 15:19
@vursen vursen requested a review from yuriy-fix August 15, 2022 18:07
@vursen vursen force-pushed the refactor/put-default-validator-behind-feature-flag branch 3 times, most recently from bb2710d to c366e44 Compare August 19, 2022 13:52
@vursen vursen force-pushed the refactor/put-default-validator-behind-feature-flag branch from c366e44 to 538a76f Compare August 19, 2022 13:52
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 27 Code Smells

No Coverage information No Coverage information
23.4% 23.4% Duplication

@vursen vursen merged commit 880a90e into master Aug 23, 2022
@vursen vursen deleted the refactor/put-default-validator-behind-feature-flag branch August 23, 2022 05:25
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.2.0.beta3 and is also targeting the upcoming stable 23.2.0 version.

@vursen vursen mentioned this pull request Aug 28, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knoobie knoobie knoobie left review comments

@yuriy-fix yuriy-fix yuriy-fix approved these changes

Assignees
No one assigned
Labels
prerelease version for Vaadin 23.2.0 Released with Vaadin 23.2.0.beta3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vursen @vaadin-bot @knoobie @yuriy-fix