Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test to label formatter used in drilldown #4215

Merged
merged 5 commits into from
Dec 8, 2022
Merged

test: add test to label formatter used in drilldown #4215

merged 5 commits into from
Dec 8, 2022

Conversation

DiegoCardoso
Copy link
Contributor

Description

Add test to address the issue described in #3867

Depends on vaadin/web-components#5080

Fixes #3867

Type of change

  • Bugfix
  • Feature

sissbruecker
sissbruecker approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@sissbruecker sissbruecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it works with the pending patch in the web component, can be merged when that is released and CI validation passes.

@sissbruecker sissbruecker marked this pull request as ready for review December 8, 2022 12:11
@sissbruecker sissbruecker enabled auto-merge (squash) December 8, 2022 12:11
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker sissbruecker merged commit ad58c6d into master Dec 8, 2022
@sissbruecker sissbruecker deleted the test/drilldown-data-label-formatter branch December 8, 2022 12:19
vaadin-bot pushed a commit that referenced this pull request Dec 8, 2022
@DiegoCardoso @web-padawan
@sissbruecker @vaadin-bot
test: add test to label formatter used in drilldown (#4215)
8ff5248 
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
vaadin-bot pushed a commit that referenced this pull request Dec 8, 2022
@DiegoCardoso @web-padawan
@sissbruecker @vaadin-bot
test: add test to label formatter used in drilldown (#4215)
a319d65 
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
web-padawan pushed a commit that referenced this pull request Dec 8, 2022
@vaadin-bot @DiegoCardoso @sissbruecker
test: add test to label formatter used in drilldown (#4215) (#4318)
7b01c2e 
Co-authored-by: Diego Cardoso <diego@vaadin.com>
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
web-padawan pushed a commit that referenced this pull request Dec 8, 2022
@vaadin-bot @DiegoCardoso @sissbruecker
test: add test to label formatter used in drilldown (#4215) (#4317)
7d6b3d6 
Co-authored-by: Diego Cardoso <diego@vaadin.com>
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

Assignees
No one assigned
Labels
cherry-picked-23.2 cherry-picked-23.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chart : DataLabels formatting function is not called when set on Series returned by DrillDownCallBack
4 participants
@DiegoCardoso @sissbruecker @vaadin-bot @web-padawan