Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement file remove listener for upload (24.4) #5789

Merged
merged 3 commits into from Dec 20, 2023

Conversation

ugur-vaadin
Copy link
Contributor

@ugur-vaadin ugur-vaadin commented Nov 28, 2023

Description

Based on the suggested API, this PR:

  • Introduces addFileRemoveListener for Upload
  • Introduces FileRemovedEvent
  • Fixes the testClearFileList test which was a false positive
  • Adds a test for the new API
  • Makes the TestBench API removeFile public

!!! IMPORTANT !!! - Should be merged to the new minor branch.

Fixes #1342

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@ugur-vaadin ugur-vaadin marked this pull request as ready for review November 28, 2023 18:41
@ugur-vaadin ugur-vaadin force-pushed the feat-implement-file-remove-listener-for-upload branch from e63c6ad to d64e4bc Compare November 30, 2023 00:24
@ugur-vaadin ugur-vaadin removed the request for review from vursen November 30, 2023 16:12
@ugur-vaadin ugur-vaadin force-pushed the feat-implement-file-remove-listener-for-upload branch from d64e4bc to 596f2b4 Compare November 30, 2023 16:13
@vursen vursen changed the title feat: implement file remove listener for upload [24.4] feat: implement file remove listener for upload Dec 12, 2023
@vursen vursen changed the title [24.4] feat: implement file remove listener for upload feat: implement file remove listener for upload (24.4) Dec 12, 2023
@ugur-vaadin ugur-vaadin force-pushed the feat-implement-file-remove-listener-for-upload branch from 596f2b4 to 62d8c71 Compare December 20, 2023 14:56
@ugur-vaadin ugur-vaadin enabled auto-merge (squash) December 20, 2023 14:56
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ugur-vaadin ugur-vaadin merged commit 37636e3 into main Dec 20, 2023
5 checks passed
@ugur-vaadin ugur-vaadin deleted the feat-implement-file-remove-listener-for-upload branch December 20, 2023 18:32
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add File remove listener, or something similiar
3 participants