Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file name to progress and file rejected listeners #5793

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

ugur-vaadin
Copy link
Contributor

@ugur-vaadin ugur-vaadin commented Nov 29, 2023

Description

This PR

  • adds file name support to progress update listeners and file rejected listeners
  • updates tests in order to check for the file names in events

The file name can be accessed via FileRejectedEvent.getFileName() and ProgressUpdateEvent.getFileName().

!!! IMPORTANT !!! - Should be merged to the new minor branch.

Fixes #1328
Fixes #3087

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@ugur-vaadin ugur-vaadin marked this pull request as ready for review November 29, 2023 23:44
@ugur-vaadin ugur-vaadin removed the request for review from DiegoCardoso November 30, 2023 16:11
@ugur-vaadin ugur-vaadin force-pushed the feat-add-file-name-to-more-upload-listeners branch from 0ac82cc to 0cef691 Compare November 30, 2023 16:12
@vursen vursen changed the title feat: add file name to progress and file rejected listeners [24.4] feat: add file name to progress and file rejected listeners Dec 12, 2023
@vursen vursen changed the title [24.4] feat: add file name to progress and file rejected listeners feat: add file name to progress and file rejected listeners (24.4) Dec 12, 2023
@ugur-vaadin ugur-vaadin force-pushed the feat-add-file-name-to-more-upload-listeners branch from da9a046 to 0dbe21f Compare December 20, 2023 18:43
@vursen vursen changed the title feat: add file name to progress and file rejected listeners (24.4) feat: add file name to progress and file rejected listeners Dec 20, 2023
@ugur-vaadin ugur-vaadin enabled auto-merge (squash) December 20, 2023 18:52
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ugur-vaadin ugur-vaadin merged commit a20151a into main Dec 20, 2023
5 checks passed
@ugur-vaadin ugur-vaadin deleted the feat-add-file-name-to-more-upload-listeners branch December 20, 2023 19:04
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants