Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop obsolete workaround from connector #6096

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Mar 5, 2024

Description

The PR drops an obsolete grid connector workaround that was introduced as a temporary fix for #5595 in 23.3. It's no longer needed because after more investigation the issue was fixed on the web component side.

Depends on

Related to #5813

Type of change

  • Refactor

@vursen vursen changed the title refactor: drop obsolete workaround from grid connector refactor: drop obsolete workaround from connector Mar 5, 2024
@vursen
Copy link
Contributor Author

vursen commented Mar 5, 2024

The test should start passing again after the new fix in the web component is released.

@vursen vursen changed the base branch from 23.3 to 23.4 March 5, 2024 10:54
@vursen vursen force-pushed the refactor/remove-obsolete-workaround branch from 3cea1d1 to cfed4a3 Compare March 5, 2024 10:55
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@vursen vursen requested a review from tomivirkki March 11, 2024 10:23
@vursen vursen merged commit a0f19b2 into 23.4 Mar 11, 2024
5 checks passed
@vursen vursen deleted the refactor/remove-obsolete-workaround branch March 11, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants