Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display null value as empty string #6178

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: display null value as empty string #6178

merged 1 commit into from
Apr 15, 2024

Conversation

ugur-vaadin
Copy link
Contributor

Description

In grid hierarchy column, the null values are currently converted to "null". This PR updates the name property provider in order to return empty string for null values.

Fixes #6159

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@ugur-vaadin ugur-vaadin force-pushed the fix-display-null-value-as-empty-string branch from 4d73d09 to 65723f4 Compare April 15, 2024 14:01
@ugur-vaadin ugur-vaadin enabled auto-merge (squash) April 15, 2024 14:01
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ugur-vaadin ugur-vaadin merged commit d5dd56c into main Apr 15, 2024
5 checks passed
@ugur-vaadin ugur-vaadin deleted the fix-display-null-value-as-empty-string branch April 15, 2024 14:24
vaadin-bot pushed a commit that referenced this pull request Apr 15, 2024
@ugur-vaadin @vaadin-bot
fix: display null value as empty string (#6178)
620ee22
yuriy-fix pushed a commit that referenced this pull request Apr 16, 2024
@vaadin-bot @ugur-vaadin @web-padawan
fix: display null value as empty string (#6178) (#6202)
ed99063 
Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha22 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.3 prerelease version for Vaadin 24.4.0 Released with Vaadin 24.4.0.alpha22 target/24.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TreeGrid hierachy column null value
3 participants
@ugur-vaadin @vaadin-bot @tomivirkki