fix: set maxFiles to Infinity when setting a MultiFileReceiver #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
commented
Apr 26, 2024
| setMaxFiles(1); | ||
| if (receiver instanceof MultiFileReceiver) { | ||
| getElement().removeProperty("maxFiles"); | ||
| getElement().executeJs("this.maxFiles = Infinity"); |
There was a problem hiding this comment.
Should we rather change the default value for this property in the web component?
There was a problem hiding this comment.
We discussed this internally and decided to go ahead with the current fix for now. We will consider changing the web component's default values later.
web-padawan
reviewed
May 15, 2024
...ad-flow-parent/vaadin-upload-flow/src/main/java/com/vaadin/flow/component/upload/Upload.java
Outdated
Show resolved
Hide resolved
|
web-padawan
approved these changes
May 20, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
May 20, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
May 20, 2024
vursen
added a commit
that referenced
this pull request
May 20, 2024
#6304) Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
vursen
added a commit
that referenced
this pull request
May 20, 2024
#6303) Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the user was unable to select more than one file after switching from a single-file receiver to a multi-file one. It was because the Flow component didn't set the
maxFilesclient-side property toInfinity– the web component's default value for that property – when a multi-file receiver was set.Fixes #6227
Type of change