-
Notifications
You must be signed in to change notification settings - Fork 160
/
TaskUpdatePackages.java
508 lines (459 loc) · 19.8 KB
/
TaskUpdatePackages.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
/*
* Copyright 2000-2022 Vaadin Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/
package com.vaadin.flow.server.frontend;
import java.io.File;
import java.io.IOException;
import java.io.UncheckedIOException;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Objects;
import java.util.Optional;
import java.util.stream.Collectors;
import java.util.stream.Stream;
import org.apache.commons.io.FileUtils;
import com.vaadin.experimental.FeatureFlags;
import com.vaadin.flow.component.dependency.NpmPackage;
import com.vaadin.flow.internal.StringUtil;
import com.vaadin.flow.server.Platform;
import com.vaadin.flow.server.frontend.scanner.ClassFinder;
import com.vaadin.flow.server.frontend.scanner.FrontendDependenciesScanner;
import elemental.json.Json;
import elemental.json.JsonObject;
import elemental.json.JsonValue;
import static com.vaadin.flow.server.Constants.PACKAGE_JSON;
import static com.vaadin.flow.server.frontend.FrontendUtils.NODE_MODULES;
/**
* Updates <code>package.json</code> by visiting {@link NpmPackage} annotations
* found in the classpath. It also visits classes annotated with
* {@link NpmPackage}.
* <p>
* For internal use only. May be renamed or removed in a future release.
*
* @since 2.0
*/
public class TaskUpdatePackages extends NodeUpdater {
protected static final String VAADIN_APP_PACKAGE_HASH = "vaadinAppPackageHash";
private final boolean forceCleanUp;
private final boolean enablePnpm;
/**
* Create an instance of the updater given all configurable parameters.
*
* @param finder
* a reusable class finder
* @param frontendDependencies
* a reusable frontend dependencies
* @param npmFolder
* folder with the `package.json` file
* @param generatedPath
* folder where flow generated files will be placed.
* @param flowResourcesPath
* folder where flow dependencies taken from resources files will
* be placed. folder where flow generated files will be placed.
* @param forceCleanUp
* forces the clean up process to be run. If {@code false}, clean
* up will be performed when platform version update is detected.
* @param enablePnpm
* if {@code true} then pnpm is used instead of npm, otherwise
* npm is used
* @param buildDir
* the used build directory
*/
TaskUpdatePackages(ClassFinder finder,
FrontendDependenciesScanner frontendDependencies, File npmFolder,
File generatedPath, File flowResourcesPath, boolean forceCleanUp,
boolean enablePnpm, String buildDir, FeatureFlags featureFlags) {
super(finder, frontendDependencies, npmFolder, generatedPath,
flowResourcesPath, buildDir, featureFlags);
this.forceCleanUp = forceCleanUp;
this.enablePnpm = enablePnpm;
}
@Override
public void execute() {
try {
Map<String, String> scannedApplicationDependencies = frontDeps
.getPackages();
JsonObject packageJson = getPackageJson();
modified = updatePackageJsonDependencies(packageJson,
scannedApplicationDependencies);
versionsPath = generateVersionsJson();
boolean npmVersionLockingUpdated = lockVersionForNpm(packageJson,
versionsPath);
if (modified || npmVersionLockingUpdated) {
writePackageFile(packageJson);
if (enablePnpm) {
// With pnpm dependency versions are pinned via pnpmfile.js.
// When updating a dependency in package.json, the old
// version may be left in the pnpm-lock.yaml file, causing
// duplicate dependencies. Work around this issue by
// deleting pnpm-lock.yaml ("pnpm install" will
// re-generate). For details, see:
// https://github.com/pnpm/pnpm/issues/2587
// https://github.com/vaadin/flow/issues/9719
deletePnpmLockFile();
}
}
} catch (IOException e) {
throw new UncheckedIOException(e);
}
}
boolean lockVersionForNpm(JsonObject packageJson, String versionsPath)
throws IOException {
if (enablePnpm) {
return false;
}
boolean versionLockingUpdated = false;
File generatedVersionsFile = new File(npmFolder, versionsPath);
final JsonObject versionsJson = Json.parse(FileUtils.readFileToString(
generatedVersionsFile, StandardCharsets.UTF_8));
JsonObject overridesSection = getOverridesSection(packageJson);
final JsonObject dependencies = packageJson.getObject(DEPENDENCIES);
for (String dependency : versionsJson.keys()) {
if (!overridesSection.hasKey(dependency)
&& dependencies.hasKey(dependency)
&& !isInternalPseudoDependency(
versionsJson.getString(dependency))) {
overridesSection.put(dependency, "$" + dependency);
versionLockingUpdated = true;
}
}
for (String dependency : overridesSection.keys()) {
if (!dependencies.hasKey(dependency)
&& overridesSection.getString(dependency).startsWith("$")) {
overridesSection.remove(dependency);
versionLockingUpdated = true;
}
}
return versionLockingUpdated;
}
private boolean isInternalPseudoDependency(String dependencyVersion) {
return dependencyVersion != null
&& dependencyVersion.startsWith("./" + buildDir);
}
private JsonObject getOverridesSection(JsonObject packageJson) {
JsonObject overridesSection = packageJson.getObject(OVERRIDES);
if (overridesSection == null) {
overridesSection = Json.createObject();
packageJson.put(OVERRIDES, overridesSection);
}
return overridesSection;
}
@Override
String writePackageFile(JsonObject json) throws IOException {
sortObject(json, DEPENDENCIES);
sortObject(json, DEV_DEPENDENCIES);
sortObject(json, VAADIN_DEP_KEY);
return super.writePackageFile(json);
}
private void sortObject(JsonObject json, String key) {
if (!json.hasKey(key)) {
return;
}
JsonObject object = json.get(key);
JsonObject ordered = orderKeys(object);
Stream.of(object.keys()).forEach(object::remove);
// add ordered keys back
Stream.of(ordered.keys()).forEach(prop -> {
JsonValue value = ordered.get(prop);
object.put(prop, value);
});
}
private JsonObject orderKeys(JsonObject object) {
String[] keys = object.keys();
Arrays.sort(keys);
JsonObject result = Json.createObject();
for (String key : keys) {
JsonValue value = object.get(key);
if (value instanceof JsonObject) {
value = orderKeys((JsonObject) value);
}
result.put(key, value);
}
return result;
}
@SuppressWarnings("squid:S134")
private boolean updatePackageJsonDependencies(JsonObject packageJson,
Map<String, String> applicationDependencies) throws IOException {
int added = 0;
JsonObject dependencies = packageJson.getObject(DEPENDENCIES);
// Update the dependency for the folder with resources
updateFlowFrontendDependencies(dependencies);
// Add application dependencies
for (Entry<String, String> dep : applicationDependencies.entrySet()) {
added += addDependency(packageJson, DEPENDENCIES, dep.getKey(),
dep.getValue());
}
/*
* #10572 lock all platform internal versions
*/
List<String> pinnedPlatformDependencies = new ArrayList<>();
final JsonObject platformPinnedDependencies = getPlatformPinnedDependencies();
for (String key : platformPinnedDependencies.keys()) {
// need to double check that not overriding a scanned
// dependency since add-ons should be able to downgrade
// version through exclusion
if (!applicationDependencies.containsKey(key)
&& pinPlatformDependency(packageJson,
platformPinnedDependencies, key)) {
added++;
}
// make sure platform pinned dependency is not cleared
pinnedPlatformDependencies.add(key);
}
if (added > 0) {
log().debug("Added {} dependencies to main package.json", added);
}
// Remove obsolete dependencies
List<String> dependencyCollection = Stream
.concat(applicationDependencies.entrySet().stream(),
getDefaultDependencies().entrySet().stream())
.map(Entry::getKey).collect(Collectors.toList());
dependencyCollection.addAll(pinnedPlatformDependencies);
boolean doCleanUp = forceCleanUp; // forced only in tests
int removed = removeLegacyProperties(packageJson);
removed += cleanDependencies(dependencyCollection, packageJson,
DEPENDENCIES);
// FIXME do not do cleanup of node_modules every time platform is
// updated ?
doCleanUp = doCleanUp || (!enablePnpm && isPlatformVersionUpdated());
// Remove obsolete devDependencies
dependencyCollection = new ArrayList<>(
getDefaultDevDependencies().keySet());
int removedDev = 0;
removedDev = cleanDependencies(dependencyCollection, packageJson,
DEV_DEPENDENCIES);
if (removed > 0) {
log().debug("Removed {} dependencies", removed);
}
if (removedDev > 0) {
log().debug("Removed {} devDependencies", removedDev);
}
if (doCleanUp) {
cleanUp();
}
String oldHash = packageJson.getObject(VAADIN_DEP_KEY)
.getString(HASH_KEY);
String newHash = generatePackageJsonHash(packageJson);
// update packageJson hash value, if no changes it will not be written
packageJson.getObject(VAADIN_DEP_KEY).put(HASH_KEY, newHash);
return added > 0 || removed > 0 || removedDev > 0
|| !oldHash.equals(newHash);
}
private int cleanDependencies(List<String> dependencyCollection,
JsonObject packageJson, String dependencyKey) {
int removed = 0;
JsonObject dependencyObject = packageJson.getObject(dependencyKey);
JsonObject vaadinDependencyObject = packageJson
.getObject(VAADIN_DEP_KEY).getObject(dependencyKey);
if (dependencyObject != null) {
for (String key : dependencyObject.keys()) {
if (!dependencyCollection.contains(key)
&& vaadinDependencyObject.hasKey(key)) {
dependencyObject.remove(key);
vaadinDependencyObject.remove(key);
log().debug("Removed \"{}\".", key);
removed++;
}
}
}
return removed;
}
private boolean pinPlatformDependency(JsonObject packageJson,
JsonObject platformPinnedVersions, String pkg) {
final FrontendVersion platformPinnedVersion = FrontendUtils
.getPackageVersionFromJson(platformPinnedVersions, pkg,
"vaadin_dependencies.json");
if (platformPinnedVersion == null) {
return false;
}
final JsonObject vaadinDeps = packageJson.getObject(VAADIN_DEP_KEY)
.getObject(DEPENDENCIES);
final JsonObject packageJsonDeps = packageJson.getObject(DEPENDENCIES);
// packages exist at this point
assert vaadinDeps != null : "vaadin{ dependencies { } } should exist";
assert packageJsonDeps != null : "dependencies { } should exist";
if (!packageJsonDeps.hasKey(pkg) || !vaadinDeps.hasKey(pkg)
|| !platformPinnedVersion.equals(
new FrontendVersion(packageJsonDeps.getString(pkg)))
|| !platformPinnedVersion.equals(
new FrontendVersion(vaadinDeps.getString(pkg)))) {
packageJsonDeps.put(pkg, platformPinnedVersion.getFullVersion());
vaadinDeps.put(pkg, platformPinnedVersion.getFullVersion());
return true;
}
return false;
}
private int updateFlowFrontendDependencies(JsonObject dependenciesObject) {
return updateNpmLocalDependency(dependenciesObject, DEP_NAME_FLOW_JARS,
flowResourcesFolder);
}
private int updateNpmLocalDependency(JsonObject dependenciesObject,
String packageName, File folder) {
assert dependenciesObject != null
: "dependency object should not be null in package.json";
if (folder != null) {
String depsPkg = "./" + FrontendUtils.getUnixRelativePath(
npmFolder.getAbsoluteFile().toPath(),
folder.getAbsoluteFile().toPath());
if (!dependenciesObject.hasKey(packageName) || !depsPkg
.equals(dependenciesObject.getString(packageName))) {
dependenciesObject.put(packageName, depsPkg);
return 1;
}
} else {
if (dependenciesObject.hasKey(packageName)) {
dependenciesObject.remove(packageName);
return 1;
}
}
return 0;
}
/**
* Compares current platform version with the one last recorded as installed
* in node_modules/.vaadin/vaadin_version. In case there was no existing
* platform version recorder and node_modules exists, then platform is
* considered updated.
*
* @return {@code true} if the version has changed, {@code false} if not
* @throws IOException
* when file reading fails
*/
private boolean isPlatformVersionUpdated() throws IOException {
// if no record of current version is present, version is not
// considered updated
Optional<String> platformVersion = Platform.getVaadinVersion();
if (platformVersion.isPresent() && nodeModulesFolder.exists()) {
JsonObject vaadinJsonContents = getVaadinJsonContents();
// If no record of previous version, version is considered updated
if (!vaadinJsonContents.hasKey(NodeUpdater.VAADIN_VERSION)) {
return true;
}
return !Objects.equals(
vaadinJsonContents.getString(NodeUpdater.VAADIN_VERSION),
platformVersion.get());
}
return false;
}
/**
* Cleans up any previous version properties from the packageJson object if
* present.
*
* @param packageJson
* JsonObject of current package.json contents
* @return amount of removed properties
* @throws IOException
* thrown if removal of package-lock.json fails
*/
private int removeLegacyProperties(JsonObject packageJson)
throws IOException {
int result = 0;
/*
* In modern Flow versions "@vaadin/flow-deps" should not exist.
*/
if (packageJson.hasKey(DEPENDENCIES)) {
JsonObject object = packageJson.getObject(DEPENDENCIES);
if (object.hasKey(DEP_NAME_FLOW_DEPS)) {
object.remove(DEP_NAME_FLOW_DEPS);
log().debug("Removed \"{}\" as it's not generated anymore.",
DEP_NAME_FLOW_DEPS);
result++;
}
}
if (packageJson.hasKey(VAADIN_APP_PACKAGE_HASH)) {
packageJson.remove(VAADIN_APP_PACKAGE_HASH);
log().debug("Removed \"{}\" as it's not used.",
VAADIN_APP_PACKAGE_HASH);
result++;
}
if (!enablePnpm) {
return result;
}
/*
* In case of PNPM tool the package-lock should not be used at all.
*/
File packageLockFile = getPackageLockFile();
if (packageLockFile.exists()) {
FileUtils.forceDelete(getPackageLockFile());
}
return result;
}
private void cleanUp() throws IOException {
FrontendUtils.deleteNodeModules(nodeModulesFolder);
if (flowResourcesFolder != null && flowResourcesFolder.exists()) {
// Clean all files but `package.json`
for (File file : flowResourcesFolder.listFiles()) {
if (!file.getName().equals(PACKAGE_JSON)) {
file.delete();
}
}
}
File generatedNodeModules = new File(generatedFolder, NODE_MODULES);
if (generatedNodeModules.exists()) {
FrontendUtils.deleteNodeModules(generatedNodeModules);
}
}
private void deletePnpmLockFile() throws IOException {
File lockFile = new File(npmFolder, "pnpm-lock.yaml");
if (lockFile.exists()) {
FileUtils.forceDelete(lockFile);
}
}
/**
* Generate hash for package dependencies. This will consider both
* 'dependencies' and 'devDependencies' of the packageJson format
* JsonObject.
* <p>
* Dependencies will be sorted by key so that different runs for same
* dependencies in different order will not trigger npm install.
*
* @param packageJson
* JsonObject built in the same format as package.json
* @return has for dependencies and devDependencies
*/
static String generatePackageJsonHash(JsonObject packageJson) {
StringBuilder hashContent = new StringBuilder();
if (packageJson.hasKey(DEPENDENCIES)) {
JsonObject dependencies = packageJson.getObject(DEPENDENCIES);
hashContent.append("\"dependencies\": {");
String sortedDependencies = Arrays.stream(dependencies.keys())
.sorted(String::compareToIgnoreCase)
.map(key -> String.format("\"%s\": \"%s\"", key,
dependencies.getString(key)))
.collect(Collectors.joining(",\n "));
hashContent.append(sortedDependencies);
hashContent.append("}");
}
if (packageJson.hasKey(DEV_DEPENDENCIES)) {
if (hashContent.length() > 0) {
hashContent.append(",\n");
}
JsonObject devDependencies = packageJson
.getObject(DEV_DEPENDENCIES);
hashContent.append("\"devDependencies\": {");
String sortedDevDependencies = Arrays.stream(devDependencies.keys())
.sorted(String::compareToIgnoreCase)
.map(key -> String.format("\"%s\": \"%s\"", key,
devDependencies.getString(key)))
.collect(Collectors.joining(",\n "));
hashContent.append(sortedDevDependencies);
hashContent.append("}");
}
return StringUtil.getHash(hashContent.toString());
}
}