Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event listeners need to support bypassing modality checks #19116

Closed
mstahv opened this issue Apr 5, 2024 · 1 comment · Fixed by #19121
Closed

event listeners need to support bypassing modality checks #19116

mstahv opened this issue Apr 5, 2024 · 1 comment · Fixed by #19121

Comments

@mstahv
Copy link
Member

mstahv commented Apr 5, 2024

Description of the bug

Events are a way more powerful mechanism to send data from client to the server. For example supporting debouncing etc. Sinse the server side modality changes, this is handicapped for certain scenarios, where events are not actual component events but somethign regarding browser/ui level. Like geolocation API, browser window size etc.

Expected behavior

The API should support allowInert() or similar annotation to bypass the checks for selected events.

Minimal reproducible example

Check the hacks needed for Viritin's geolocation API to work when a dialog is open.

Versions

  • Vaadin / Flow version: 24.3
@mstahv
Copy link
Member Author

mstahv commented Apr 5, 2024

Created a draft PR. Would still need some unit tests, but actual functionality tested manually with/in #19122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants