Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bundling by default and use the new version in skeleton starter and beveragebuddy #3317

Closed
SomeoneToIgnore opened this issue Jan 16, 2018 · 1 comment
Assignees
Milestone

Comments

@SomeoneToIgnore
Copy link
Contributor

@SomeoneToIgnore commented on Wed Jan 10 2018

Users may want to test out the app before reading the documentation, we need to add bundling there so that they have better experience.

We should also add an info to the starters' README explaining on how they are able to create a production build.

We should

  • set enabled property to true by default in the corresponding mojo
  • release a new plugin
  • update the plugin docs
  • update the starters' poms and readmes

@Legioth commented on Fri Jan 12 2018

I guess this would still only affect production builds? Running bundling every time I do mvn jetty:run would a quite bad experience.


@SomeoneToIgnore commented on Fri Jan 12 2018

Yes, it will bundle every time only if you run mvn jetty:run -PproductionMode

@SomeoneToIgnore
Copy link
Contributor Author

Branch with changes: https://github.com/vaadin/flow/tree/kb/3317_bundling-enabled-by-default

Awaits #3313 that will bring in the documentation change.
After it's merged, the docs should be updated in the branch and the PR can be created afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants