Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to make people notice that they are missing @Theme #3338

Closed
pleku opened this issue Jan 17, 2018 · 0 comments
Closed

Try to make people notice that they are missing @Theme #3338

pleku opened this issue Jan 17, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@pleku
Copy link
Contributor

pleku commented Jan 17, 2018

When creating an app based on a starter and adding a new navigation target structure, if I forget to add the Theme annotation, I get a very ugly UI and don't know what to do without reading docs

Since the Vaadin elements are not really meant to be used as directly the un-themed versions from /src/ folder, we should make it as clear as possible to tell the users that they are missing the @Theme annotation from the page they opened.

One option was to apply Lumo by default, but we discarded this because it has some unfortunate side-effects for advanced users building their own themes or not using Lumo or our components, and would force us to try to detect for both the Lumo resources presence and whether @Theme is present or not.

For now let's just add logging with warning level to the server console when no @Theme is present and we are serving the unthemed versions of Vaadin Components, since those are not meant to be used.

@pleku pleku added the DX label Jan 17, 2018
@pleku pleku added this to the 1.0.0.alpha18 milestone Jan 18, 2018
@pleku pleku closed this as completed Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants