Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreserveOnRefresh & Browser related data API for Flow #4665

Closed
pleku opened this issue Oct 4, 2018 · 5 comments
Closed

PreserveOnRefresh & Browser related data API for Flow #4665

pleku opened this issue Oct 4, 2018 · 5 comments
Labels
Milestone

Comments

@pleku
Copy link
Contributor

pleku commented Oct 4, 2018

Epic consisting of subissues for adding API to server side to know more about browser details.

@pleku pleku added the Epic label Oct 4, 2018
@pleku pleku added this to the V13 Candidates milestone Oct 10, 2018
@pleku pleku changed the title EPIC: Browser related data Browser related data API for Flow Oct 12, 2018
@pleku pleku modified the milestones: V13 Candidates, V14 Candidates Nov 13, 2018
@pleku pleku moved this from Candidates for Vaadin 13 to Candidates for Vaadin 14 in No longer in use, go to https://vaadin.com/roadmap Nov 13, 2018
@pleku pleku changed the title Browser related data API for Flow PreserveOnRefresh & Browser related data API for Flow Nov 22, 2018
@syampillai
Copy link

syampillai commented Dec 15, 2018

I'm looking forward to PreserveOnRefresh feature.

Currently, I have a problem with a Flow application viewing from a mobile. The application's main view contains mainly a Grid and the users swipe up and down to scroll the Grid. Chrome (Android) reloads the page when a swipe-up is not handled by the component inside. In the case of the Grid, it handles swipe-up to scroll the Grid but if the Grid's scroll position is already at the top, it will pass that event to the browser and thus, an unwanted reload will happen.

@pleku
Copy link
Contributor Author

pleku commented Dec 16, 2018

In the case of the Grid, it handles swipe-up to scroll the Grid but if the Grid's scroll position is already at the top, it will pass that event to the browser and thus, an unwanted reload will happen.

Hi @syampillai, I think this is worth an issue in vaadin/vaadin-grid repository. If that happens often for your users in your app, then the default action for that event should be prevented (the refresh). You can try to search if you can catch that event on some else level in the DOM and prevent the default for Android Chrome. Using @PreserveOnRefresh would seem to me a way to just workaround the bad UX.

@pleku pleku moved this from Vaadin 14 to Candidates for Vaadin 15 in No longer in use, go to https://vaadin.com/roadmap Mar 8, 2019
@heruan
Copy link
Member

heruan commented Apr 5, 2019

Hm, this is on the V14 milestone but in V15 project: I really hope it's V14 😄 (at least for the browser data, like the user time-zone)

@pleku
Copy link
Contributor Author

pleku commented Apr 5, 2019

There is already a low level feature that enabling this* in the latest 2.0 alpha and are looking at how we provide the value for 14.

*It meaning requesting any data from client and reacting to it. Like time zone. Or window.name, which is needed for preserveonrefresh type of reusing existing UI and its components.

@pleku pleku moved this from Candidates for Vaadin 15 to Vaadin 14 in No longer in use, go to https://vaadin.com/roadmap May 3, 2019
@pleku
Copy link
Contributor Author

pleku commented May 3, 2019

Closing this Epic as the following are available in Flow 2.0 (Vaadin 14):

@pleku pleku closed this as completed May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants