Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify usage of set(Min/Max)(Height/Width) in HasSize #5854

Open
edler-san opened this issue Jun 6, 2019 · 3 comments
Open

Clarify usage of set(Min/Max)(Height/Width) in HasSize #5854

edler-san opened this issue Jun 6, 2019 · 3 comments

Comments

@edler-san
Copy link

edler-san commented Jun 6, 2019

The above mentioned methods only work on block level elements. Improve the documentation for the respective methods.

PR is here: #5855

@pleku
Copy link
Contributor

pleku commented Dec 20, 2019

As discussed in the PR #5855, we should:

  • add a new interface for the set&get-min&max-width&height-methods, with a suitable name
  • deprecate the API in HasSize with instructions that it might not work for certain components (inline), and instruct for component developers to use the API in the new interface instead
  • update all Vaadin components that actually can support the min&max API to use the new interface instead to make sure the deprecated API is not visible

Anything else ?

@pleku
Copy link
Contributor

pleku commented Dec 20, 2019

It probably would be nice to get this resolved in Flow 2.2 (adding deprecations) so that we could remove the methods in 3.0., related to #6510

@pleku pleku added this to Inbox - needs triage in OLD Vaadin Flow ongoing work (Vaadin 10+) Dec 20, 2019
@pleku pleku added the DX label Dec 20, 2019
@pleku pleku moved this from Inbox - needs triage to Parking lot - under consideration in OLD Vaadin Flow ongoing work (Vaadin 10+) Aug 19, 2020
@pleku
Copy link
Contributor

pleku commented Aug 19, 2020

For now it would be good to:

  • remove the methods in master branch of Flow
  • for next 2.x branch deprecate the methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Parking lot - under consideration
Status: 🅿️Parking lot - under consideration
Development

No branches or pull requests

4 participants