Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new components sometimes cause client side errors #6027

Closed
mstahv opened this issue Jul 5, 2019 · 4 comments
Closed

Adding new components sometimes cause client side errors #6027

mstahv opened this issue Jul 5, 2019 · 4 comments

Comments

@mstahv
Copy link
Member

mstahv commented Jul 5, 2019

Mac, JDK 11 or 12, Vaadin 14.0.0.rc3, npm 6.8

With this procedure I can reproduce this in a deterministic way.

  1. Download Spring Boot starter from vaadin.com/start
  2. Import to IntelliJ
  3. Run a priming Maven build (mvn install)
  4. Execute Application class fron IDE
  5. Navigate to localhost:8080
  6. Stop execution
  7. Run a clean build (mvn clean install)
  8. Execute Application class fron IDE
  9. Navigate to localhost:8080
  10. Change the MainView, e.g. add(new DatePicker());
  11. reload browser -> boom
@project-bot project-bot bot added this to Inbox - needs triage in OLD Vaadin Flow ongoing work (Vaadin 10+) Jul 5, 2019
@mstahv mstahv added the bug label Jul 5, 2019
@mehdi-vaadin mehdi-vaadin moved this from Inbox - needs triage to Product backlog in OLD Vaadin Flow ongoing work (Vaadin 10+) Jul 8, 2019
@mehdi-vaadin
Copy link
Contributor

It may be the same as #6029.

@mehdi-vaadin mehdi-vaadin moved this from Product backlog to Iteration Backlog in OLD Vaadin Flow ongoing work (Vaadin 10+) Jul 10, 2019
@mehdi-vaadin mehdi-vaadin self-assigned this Jul 17, 2019
@project-bot project-bot bot moved this from Iteration Backlog to In progress in OLD Vaadin Flow ongoing work (Vaadin 10+) Jul 17, 2019
@caalador
Copy link
Contributor

Works as expected with windows and rc5.
Please try it out with the upcoming rc6 and reopen ticket with more details if problem persists.

OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from In progress to Done - pending release Jul 17, 2019
@mehdi-vaadin mehdi-vaadin added this to the 2.0.4 milestone Jul 17, 2019
@mstahv
Copy link
Member Author

mstahv commented Aug 5, 2019

Just tried it out (rc7) and it failed for me.

@Legioth
Copy link
Member

Legioth commented Aug 6, 2019

This happens because mvn clean install will create a production bundle for you and running the project directly from the IDE will keep using that production bundle. After you have made changes to your project, the production bundle is no longer in sync with the updated Java classes -> boom.

We plan on fixing this by making it so that mvn clean install would by default no create a production bundle for you but instead only set up things for using the webpack dev server. More details in #6137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Development

No branches or pull requests

4 participants