Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure bootstrapping compatibility with V14 #6136

Closed
vlukashov opened this issue Jul 31, 2019 · 1 comment
Closed

Ensure bootstrapping compatibility with V14 #6136

vlukashov opened this issue Jul 31, 2019 · 1 comment
Assignees
@qtdzz
Labels
hilla Issues related to Hilla
Milestone
CCDM MVP

Comments

@vlukashov
Copy link

vlukashov commented Jul 31, 2019 •
edited

When upgrading a Vaadin app from V14 to V15, I want the response to my HTTP GET request to come from the V14 BootstrapHandler, so that the existing server-side bootstrapping keeps working and I do not have to rewrite the app to use client-side bootstrapping.

  • add a clientSideBootstrap property (Servlet parameter) similar to compatibilityMode
  • the default value of clientSideBootstrap is false (use server-side bootstrapping)
  • keep the existing BootstrapHandler (if clientSideBootstrap is false)
  • the Maven plugin needs to know that property as well (thus, it needs to be a maven property that's put to the token file)
  • that will have all the same problems as the npm model property (not set if started e.g. directly from Eclipse)
@vlukashov vlukashov transferred this issue from vaadin/vaadin-connect Jul 31, 2019
@project-bot project-bot bot added this to Inbox - needs triage in OLD Vaadin Flow ongoing work (Vaadin 10+) Jul 31, 2019
@vlukashov vlukashov mentioned this issue Jul 31, 2019
Closed
@qtdzz qtdzz mentioned this issue Aug 2, 2019
Merged
@pleku pleku removed this from Inbox - needs triage in OLD Vaadin Flow ongoing work (Vaadin 10+) Aug 5, 2019
@manolo manolo added the hilla Issues related to Hilla label Aug 5, 2019
@qtdzz qtdzz self-assigned this Aug 6, 2019
@qtdzz qtdzz mentioned this issue Aug 9, 2019
Merged
@qtdzz
Copy link
Contributor

qtdzz commented Aug 9, 2019

The property was added in #6167.
#6186 finalizes it by using the property to generate proper webpack config for the new mode.

@qtdzz qtdzz closed this as completed Aug 9, 2019
@vlukashov vlukashov added this to the CCDM MVP milestone Aug 12, 2019
@vlukashov vlukashov mentioned this issue Feb 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qtdzz qtdzz

Labels
hilla Issues related to Hilla
Projects
None yet
Milestone
CCDM MVP
Development

No branches or pull requests
3 participants
@manolo @qtdzz @vlukashov