Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Livereload of frontend resources shows error when it should not #8965

Closed
Artur- opened this issue Sep 8, 2020 · 1 comment · Fixed by #8990
Closed

Livereload of frontend resources shows error when it should not #8965

Artur- opened this issue Sep 8, 2020 · 1 comment · Fixed by #8990

Comments

@Artur-
Copy link
Member

Artur- commented Sep 8, 2020

Description of the bug

When making frontend changes and you have an error, you need to fix the error, save and the save again for the change to be taken into use, or at least for the error popup to disappear

Minimal reproducible example

git clone https://github.com/vaadin/cookbook.git
cd cookbook
mvn
  1. Wait for it to start

  2. open http://localhost:8080/

  3. Add a in the beginning of frontend/views/recipes-list-view.ts
    The browser reloads and shows an empty view, as expected

  4. Remove a from the beginning of the file

Expected behavior

The browser reloads and shows the original view

Actual behavior

The browser reloads, shows the original view and a large popup about a webpack error that did not occur.
It includes among other things errors about aimport so it seems a bit like the old webpack error is shown.

Versions:

- Vaadin version: 17
@joheriks
Copy link
Contributor

joheriks commented Sep 9, 2020

There are actually two problems here: in addition to the aimport error being erroneously shown after the correction, I would expect in step (4) that error to be shown on top of the empty view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants