Skip to content

Commit

Permalink
Split VOverlay functionality to a new base class (#19347)
Browse files Browse the repository at this point in the history
This fixes the missing z-index for the Grid popup.

Change-Id: I5474fe653ad4ece38e9bc3cb2331a1d2190ea898
  • Loading branch information
Teemu Suo-Anttila authored and Vaadin Code Review committed Jan 12, 2016
1 parent 7b7ead6 commit a963263
Show file tree
Hide file tree
Showing 5 changed files with 1,071 additions and 1,010 deletions.
75 changes: 39 additions & 36 deletions client/src/com/vaadin/DefaultWidgetSet.gwt.xml
@@ -1,39 +1,42 @@
<module> <module>
<!-- This GWT module defines the Vaadin DefaultWidgetSet. This is the <!-- This GWT module defines the Vaadin DefaultWidgetSet. This is the module
module you want to extend when creating an extended widget set, or when creating you want to extend when creating an extended widget set, or when creating
a specialized widget set with a subset of the components. --> a specialized widget set with a subset of the components. -->


<!-- Hint for WidgetSetBuilder not to automatically update the file --> <!-- Hint for WidgetSetBuilder not to automatically update the file -->
<!-- WS Compiler: manually edited --> <!-- WS Compiler: manually edited -->


<inherits name="com.vaadin.Vaadin" /> <inherits name="com.vaadin.Vaadin" />


<!-- Elemental is used for handling Json only --> <!-- Elemental is used for handling Json only -->
<inherits name="elemental.Json" /> <inherits name="elemental.Json" />


<inherits name="com.google.gwt.precompress.Precompress"/> <inherits name="com.google.gwt.precompress.Precompress" />


<entry-point class="com.vaadin.client.ApplicationConfiguration" /> <entry-point class="com.vaadin.client.ApplicationConfiguration" />


<generate-with <generate-with
class="com.vaadin.server.widgetsetutils.AcceptCriteriaFactoryGenerator"> class="com.vaadin.server.widgetsetutils.AcceptCriteriaFactoryGenerator">
<when-type-is class="com.vaadin.client.ui.dd.VAcceptCriterionFactory" /> <when-type-is class="com.vaadin.client.ui.dd.VAcceptCriterionFactory" />
</generate-with> </generate-with>


<generate-with <generate-with
class="com.vaadin.server.widgetsetutils.ConnectorBundleLoaderFactory"> class="com.vaadin.server.widgetsetutils.ConnectorBundleLoaderFactory">
<when-type-assignable <when-type-assignable
class="com.vaadin.client.metadata.ConnectorBundleLoader" /> class="com.vaadin.client.metadata.ConnectorBundleLoader" />
</generate-with> </generate-with>


<replace-with <replace-with class="com.vaadin.client.communication.DefaultReconnectDialog">
class="com.vaadin.client.communication.DefaultReconnectDialog"> <when-type-is class="com.vaadin.client.communication.ReconnectDialog" />
<when-type-is class="com.vaadin.client.communication.ReconnectDialog" /> </replace-with>
</replace-with>

<replace-with class="com.vaadin.client.ui.VOverlay">
<!-- Since 7.2. Compile all permutations (browser support) into one Javascript <when-type-is class="com.vaadin.client.widgets.Overlay" />
file. Speeds up compilation and does not make the Javascript significantly </replace-with>
larger. -->
<collapse-all-properties /> <!-- Since 7.2. Compile all permutations (browser support) into one Javascript
file. Speeds up compilation and does not make the Javascript significantly
larger. -->
<collapse-all-properties />


</module> </module>

0 comments on commit a963263

Please sign in to comment.