Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Page.pushState() can cause browser to load resources from wrong URLs #10329

Closed
Wnt opened this issue Nov 16, 2017 · 7 comments
Closed

Using Page.pushState() can cause browser to load resources from wrong URLs #10329

Wnt opened this issue Nov 16, 2017 · 7 comments

Comments

@Wnt
Copy link
Contributor

Wnt commented Nov 16, 2017

  • Vaadin Framework version 8.2.0.alpha2

When you call Page.pushState() in the enter method of a View the browser (Chromium version 62.0.3202.75) to load favicon from a wrong url:
navigate to
https://vaadinfiddle.com/editor/container/musing_northcutt
(the app is using @PushStateNavigation with navigator)
the browser tries to load favicon from:
https://vaadinfiddle.com/editor/container/musing_northcutt/src/main/java/org/vaadin/VAADIN/themes/vaadin-fiddle/favicon.ico

The View that opens from https://vaadinfiddle.com/editor/container/musing_northcutt calls Page.getCurrent().pushState("https://vaadinfiddle.com/editor/container/musing_northcutt/src/main/java/org/vaadin/vaadinfiddle/MyUI.java");
in the enter method.

I guess the relative path the browser is trying to use for the favicon is only valid for the initial page URL, but not for the pushed URL anymore.

@stale
Copy link

stale bot commented Apr 15, 2018

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Apr 15, 2018
@elmot
Copy link
Contributor

elmot commented Apr 23, 2018

Is the issue reproducible outside of vaadinfiddle?

@stale stale bot removed the Stale Stale bot label label Apr 23, 2018
@Wnt
Copy link
Contributor Author

Wnt commented Apr 23, 2018

@elmot Yes.

@Wnt
Copy link
Contributor Author

Wnt commented Apr 23, 2018

Minimal project where the problem is reproducible:
https://github.com/Wnt/pushstatetest
steps to reproduce:

  1. start app with mvn jetty:run
  2. navigate to http://localhost:8080/first-view
  3. browser tries to load favicon from http://localhost:8080/first-view/VAADIN/themes/valo/favicon.ico

what should happen instead:

Browser should load the favicon from: http://localhost:8080/VAADIN/themes/valo/favicon.ico

@chvndb
Copy link

chvndb commented Jun 13, 2018

@Wnt Having the same issue here. Did you find a solution for this yet?

@stale
Copy link

stale bot commented Nov 10, 2018

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Nov 10, 2018
@Ansku Ansku added BFP and removed Stale Stale bot label labels Jun 11, 2019
@TatuLund
Copy link
Contributor

We have been unable to reproduce this since Vaadin 8.8.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants