-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Page.pushState() can cause browser to load resources from wrong URLs #10329
Comments
Hello there! It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe. There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):
Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too! |
Is the issue reproducible outside of vaadinfiddle? |
@elmot Yes. |
Minimal project where the problem is reproducible:
what should happen instead: Browser should load the favicon from: http://localhost:8080/VAADIN/themes/valo/favicon.ico |
@Wnt Having the same issue here. Did you find a solution for this yet? |
Hello there! We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet. There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):
Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too! |
We have been unable to reproduce this since Vaadin 8.8.5 |
When you call
Page.pushState()
in the enter method of a View the browser (Chromium version 62.0.3202.75) to load favicon from a wrong url:navigate to
https://vaadinfiddle.com/editor/container/musing_northcutt
(the app is using
@PushStateNavigation
with navigator)the browser tries to load favicon from:
https://vaadinfiddle.com/editor/container/musing_northcutt/src/main/java/org/vaadin/VAADIN/themes/vaadin-fiddle/favicon.ico
The View that opens from https://vaadinfiddle.com/editor/container/musing_northcutt calls
Page.getCurrent().pushState("https://vaadinfiddle.com/editor/container/musing_northcutt/src/main/java/org/vaadin/vaadinfiddle/MyUI.java");
in the enter method.
I guess the relative path the browser is trying to use for the favicon is only valid for the initial page URL, but not for the pushed URL anymore.
The text was updated successfully, but these errors were encountered: