Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeGrid with height set to 100% causes missing entries on reload and flickering #10501

Closed
focbenz opened this issue Jan 8, 2018 · 10 comments
Closed

Comments

@focbenz
Copy link
Contributor

focbenz commented Jan 8, 2018

If a TreeGrid with fixed width and height set to 100% some entries after a specific item start to flicker when the TreeGrid is reloaded and some entries might disappear. This issue has been following us since Vaadin 8 was introduced and can still be repoduced in the latest 8.1.7 or 8.2.0 Vaadin release.

vaadin8missingnavigationentriesintreegrid

We use the grid to show a navigation menu on the left side of the application as demonstrated the sample below

Sample project that reproduces the issue with a minimal setup:
https://github.com/FOCONIS/disappearing-nav-entries

Sample code:

                private TreeGrid<NavigationEntry> navigationTree = new TreeGrid<>();
(...)
		TreeDataProvider<NavigationEntry> dataProvider = new TreeDataProvider<>(data);
		navigationTree.setDataProvider(dataProvider);

		navigationTree.setWidth("250px");
		// Setting the height to 100% causes problem with flickering grid and disappearing items
		navigationTree.setHeight("100%");
		// Workaround: Use a fixed height for the grid and the flickering goes away
		//navigationTree.setHeight("700px");
@stale
Copy link

stale bot commented Jun 7, 2018

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Jun 7, 2018
@focbenz
Copy link
Contributor Author

focbenz commented Jun 8, 2018

Please attack this issue ... very annoying issue since we use this element for our navigation.
Also we already tracked down the root cause ... but currently still need to use the 100% height.

@stale stale bot removed the Stale Stale bot label label Jun 8, 2018
@focbenz
Copy link
Contributor Author

focbenz commented Jul 11, 2018

Vaadin Version 8.4.3 made the problem seriously worse ... whole parts of the navigation were missing.
Updating to latest 8.4.5 at least reduced the problem to the originally reported just "disappearing" single entries.

@stale
Copy link

stale bot commented Dec 8, 2018

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Dec 8, 2018
@focbenz
Copy link
Contributor Author

focbenz commented Dec 11, 2018

We are not currently monitoring this issue anymore ... it might still be valid for other Vaadin users.

@stale stale bot removed the Stale Stale bot label label Dec 11, 2018
@stale
Copy link

stale bot commented May 10, 2019

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label May 10, 2019
@focbenz
Copy link
Contributor Author

focbenz commented May 13, 2019

There is sample code that could be turned into a Testbench test case ... if that is not enough the only option is to fix this issue yourself if you are also affected.

@stale stale bot removed the Stale Stale bot label label May 13, 2019
@stale
Copy link

stale bot commented Oct 10, 2019

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Oct 10, 2019
@focbenz
Copy link
Contributor Author

focbenz commented Oct 10, 2019

Seems to be fixed in Vaadin 8.9.1 ... sample project cannot reproduce the issue.

@stale stale bot removed the Stale Stale bot label label Oct 10, 2019
@TatuLund
Copy link
Contributor

TatuLund commented Oct 19, 2019

Thanks for your effort in testing. We did major fix in Escalator and expected it to fix some other issues as byproduct.

Fixed by #11438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants