Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid drag & drop with MobileHtml5Dnd #11219

Closed
OlliTietavainenVaadin opened this issue Oct 3, 2018 · 12 comments
Closed

Grid drag & drop with MobileHtml5Dnd #11219

OlliTietavainenVaadin opened this issue Oct 3, 2018 · 12 comments

Comments

@OlliTietavainenVaadin
Copy link
Member

Mentioned in #9974:

Vaadin framework 8.1.7. Linux Ubuntu 16.04 Chrome 63
With setMobileHtml5DndEnabled(true) , on a Grid, we can drag only the first element.
I can reproduce the problem on "https://demo.vaadin.com/sampler/#ui/drag-drop/grid-reorder-rows-html5".

and related to the same:

Can reproduce still. This makes the Grid DnD feature really unusable on (some) Win10 computers.

I cannot reproduce the issue on a non-touchscreen Windows 10 laptop, so the issue needs to be tested with touchscreen device.

@drewoko
Copy link

drewoko commented Oct 3, 2018

We also mentioned D&D problems with touchscreen laptops.

Prioritized issue in Warranty .

@OlliTietavainenVaadin
Copy link
Member Author

@drewoko can you tell which specific browsers are affected?

@drewoko
Copy link

drewoko commented Oct 3, 2018

We tried FF and Chrome

@OlliTietavainenVaadin
Copy link
Member Author

Demo project that reproduces the issue: https://github.com/OlliTietavainenVaadin/grid-drag-demo

@ZheSun88
Copy link
Contributor

ZheSun88 commented Nov 5, 2018

from @sarahfuchs

For our project the problem can be summarized as follows:
vaadin version 8.6.0
used code: grid with drag & drop
Classes Grid, GridDropTarget, RowMoveListener
Bug: on Notebook touch, IE the drag&drop does not work.
The notebook touch is: Suface Pro 4, Windows 10
Other setups (IE on a PC or Chrome on Notebook touch) are working fine

Our code base is quite large. If you need specific Code snippets, please let me know.
Since its only the customer who works wich Notebook touch its complicated to write a simple test case.

@ZheSun88
Copy link
Contributor

ZheSun88 commented Nov 5, 2018

Hi @sarahfuchs, I have tested with a few sample projects (including the one in this ticket) on a Surface with Win10. it looks the drag and drop which is triggered by the mouse event works correctly, but with touch event, it doesn't work.
will do more investigations.

@ZheSun88 ZheSun88 self-assigned this Nov 6, 2018
@ZheSun88 ZheSun88 removed their assignment Nov 22, 2018
@sirbris
Copy link

sirbris commented Nov 27, 2018

any news on that issue? some of our customers are still experiencing problems with drag&drop on touch devices (seems to be only a problem with Win10)

@ZheSun88 ZheSun88 self-assigned this Jan 3, 2019
@ZheSun88
Copy link
Contributor

ZheSun88 commented Jan 4, 2019

Sorry for the long delay. This issue is mainly related to use DnD feature on hybrid devices like Surface Pro, but Could you @sirbris be more elaborated with the problem that your customer is having?

We have identified one issue that only the first row in grid can be dragged by mouse before, but that has been fixed by updating to Chrome 71. Maybe you can try with this also.

@ZheSun88 ZheSun88 assigned ZheSun88 and unassigned ZheSun88 Jan 4, 2019
@sirbris
Copy link

sirbris commented Jan 11, 2019

Thank you for your investigation. I couldn't reproduce this issue on my own pc either but some of our customers still experience problems concerning drag&drop... only with Win10, regardless of the browser though.

@ZheSun88
Copy link
Contributor

What kind of device are they using? and what kind of scenario are they facing?
regardless of the browser sounds quite bad .

@sirbris
Copy link

sirbris commented Jan 23, 2019

It was a Dell notebook with touch display and Windows 10... at the moment I could not get more specifics.

@ZheSun88 ZheSun88 removed their assignment Jan 25, 2019
@TatuLund
Copy link
Contributor

After long investigation we have not been able to find the root cause of this, and no reproducing example and setup is available. It is clear that something is probably causing issues with in selected corner cases. It is most likely problem in the polyfill used, i.e. https://github.com/timruffles/mobile-drag-drop It is noted that framework uses older version https://github.com/vaadin/framework/blob/master/server/src/main/resources/VAADIN/drag-drop-polyfill.min.js We tried newer version before Christmas, but it did not help. So I cam closing this as wontfix for now. We may revisit this if there is progress in polyfill library used and need to update the version used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants