New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error-related methods should be in Field interface, not AbstractComponent #3140
Comments
Originally by @marlonrichert Or in other words: We should not have error handling on components that do not allow the user to enter values. It simply doesn't make sense. If an error occurs that is not related to the user entering invalid data, then that indicates a programming error that's too serious to be handled with just an error indicator. A Notification should be shown instead. |
Originally by @thinwire This is a non-trivial API change, and a proper course of action is still being debated. |
Originally by @Legioth Hi, this ticket has been in the accepted state without any updates for a long time. Is someone still working on this? If not, then please select "no longer working on this" in the Actions box below so that anyone else interested in investigating can know there's nobody else working on it. |
Hello there! It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe. There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):
Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too! |
The issue was automatically closed due to inactivity. If you found some new details to it or started working on it, comment on the issue so that maintainers can re-open it. |
Originally by @marlonrichert
Components that are not Fields should not be able to have error indicators: On non-interactive Components, such as Labels and ComponentContainers, having an error API does not make any sense at all. The only non-Field components were errors make sense are controls that can initiate actions, such as Buttons, but even then, when something goes wrong after pressing a Button, an error indicator is not the way to go! In those kind of cases, Vaadin should show a proper Notification to the user instead. Thus, non-Field Components are better off without an error API.
Therefore, please declare the following methods in the Field interface and move their implementations from AbstractComponent to AbstractField:
Or, instead of declaring them directly in Field, we could also put them in a separate
Fallible
interface for them.Imported from https://dev.vaadin.com/ issue #10199
The text was updated successfully, but these errors were encountered: