Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractCommunicationManager methods not depending on internal state should be moved #3706

Open
vaadin-bot opened this issue Mar 25, 2013 · 1 comment

Comments

@vaadin-bot
Copy link
Collaborator

vaadin-bot commented Mar 25, 2013

Originally by @jdahlstrom


AbstractCommunicationManager contains utility methods that do not depend on ACM state. These should be moved to an Util class if they don't seem to fit anywhere else.

  • encodeState
  • getStreamVariableTargetUrl
  • getConnector (depends on DnD service; see Move DragAndDropService to VaadinSession #3704)
  • handleConnectorRelatedException
  • isConnectorVisibleToClient
  • isComponentVisibleToClient
  • getDirtyVisibleConnectors (should be removed)
@stale
Copy link

stale bot commented Mar 21, 2018

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Mar 21, 2018
@stale stale bot removed the Stale Stale bot label label Feb 26, 2020
@TatuLund TatuLund added enhancement Stale Stale bot label labels Feb 26, 2020
@stale stale bot removed the Stale Stale bot label label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants