Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin: 8.0.4. Setting gridHeightMode(HeidhtMode.Undefined) results in displaying wrong amount of rows #9020

Closed
anasmi opened this issue Apr 5, 2017 · 2 comments
Milestone

Comments

@anasmi
Copy link
Contributor

anasmi commented Apr 5, 2017

Setting grid to grid.setHeightMode(HeightMode.UNDEFINED); resuts in wrong amount of rows to be displayed.

Code to reproduce:
final VerticalLayout layout = new VerticalLayout();
List people = Arrays.asList(new Person("Nicolaus Copernicus", 1543),
new Person("Galileo Galilei", 1564), new Person("Johannes Kepler1", 1571),
new Person("Johannes Kepler2", 1571), new Person("Johannes Kepler3", 1571));

	// Create a grid bound to the list
	Grid<Person> grid = new Grid<>();
	grid.setItems(people);
	grid.addColumn(Person::getName).setCaption("Name");
	grid.addColumn(Person::getBirthYear).setCaption("Year of birth");
	grid.setHeightMode(HeightMode.UNDEFINED);
	grid.setWidth("900px");
	layout.addComponent(grid);
	setContent(layout);
@anasmi
Copy link
Contributor Author

anasmi commented Apr 5, 2017

gridwrong

@tsuoanttila
Copy link
Contributor

There was a fix for this in pull request #9104 merged to master yesterday. Will be picked to 8.0 and one part of the patch might apply for 7.7 as well.

@tsuoanttila tsuoanttila added this to the 8.0.6 milestone May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants