Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing valueproviders after column creation #9280

Closed
sirbris opened this issue May 10, 2017 · 3 comments
Closed

Allow changing valueproviders after column creation #9280

sirbris opened this issue May 10, 2017 · 3 comments
Labels
Stale Stale bot label

Comments

@sirbris
Copy link

sirbris commented May 10, 2017

Vaadin 8.1.0.alpha6
It should be possible to set or change the ValueProvider in a Grid (like you now can with Renderer) after columns have been created.

@divid3byzero
Copy link

+1 for this.

It can be real pain especially if you need to create grids dynamically and do not know the exact number of columns that you will be having.

@tsuoanttila
Copy link
Contributor

Changing of the ValueProvider in a Column is not allowed for type safety reasons. We would need you, the user, to provide the ValueProvider for the column, a new renderer an possibly even a new ValueProvider for the renderer, possibly a new editor component and sorting instructions. If you absolutely must change the whole type of the column every now and then, I'd recommend doing:

Grid<T> grid;
Column<T, T> fullBeanColumn = grid.addColumn(t -> t);

and just change the renderer and it's value extractor. This is an ugly way to do it, but it can be done. Preferably if you need to get a different type of column you should make a new column.

This is only possible with the changes in 8.1.

@stale
Copy link

stale bot commented Mar 19, 2018

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Mar 19, 2018
@sirbris sirbris closed this as completed Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Stale bot label
Projects
None yet
Development

No branches or pull requests

3 participants