Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioButtonGroup/CheckBoxGroup: setting ClassResource as icon renders a broken link #9536

Closed
mvysny opened this issue Jun 14, 2017 · 6 comments
Labels
Stale Stale bot label

Comments

@mvysny
Copy link
Member

mvysny commented Jun 14, 2017

Vaadin 8.1.0.beta1. Setting setItemIconGenerator() which produces ClassResource produces broken URLs and won't download the resource properly. Attaching screenshot.
screenshot_20170614_220934

@mvysny
Copy link
Member Author

mvysny commented Jun 14, 2017

The URL produced is http://localhost:8080/APP/connector/0/56/null/document32.png - that null looks suspicious.

@hesara
Copy link
Contributor

hesara commented Jun 21, 2017

The null key given in AbstractMultiSelect.MultiSelectDataGenerator might or might not be related to the problem.

In any case, I suspect this might apply to all ConnectorResource instances (ClassResource, FileResource, StreamResource) and potentially also to some other listing components - to check when addressing this.

@stale
Copy link

stale bot commented Mar 19, 2018

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Mar 19, 2018
@MartinUhlen
Copy link

Any progress on this issue?

#9041 fixed the corresponding issue for ComboBox, same thing needed here?

@stale stale bot removed the Stale Stale bot label label Oct 11, 2018
@stale
Copy link

stale bot commented Mar 10, 2019

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Mar 10, 2019
@stale
Copy link

stale bot commented Jan 9, 2022

The issue was automatically closed due to inactivity. If you found some new details to it or started working on it, comment on the issue so that maintainers can re-open it.

@stale stale bot closed this as completed Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Stale bot label
Projects
None yet
Development

No branches or pull requests

3 participants