Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBox last selected item caption not cleared if new collection is passed #9566

Closed
mattesnom opened this issue Jun 21, 2017 · 8 comments
Closed
Labels
duplicate Stale Stale bot label
Milestone

Comments

@mattesnom
Copy link

mattesnom commented Jun 21, 2017

Vaadin Version 8.0.6

cmb = new ComboBox<>("My ComboBox");
cmb.setEmptySelectionAllowed(false);
cmb.setTextInputAllowed(false);
cmb.setItems(aCollectionOfItems);
cmb.setValue(firstItem);

The ComboBox selects the Item and displays it's name.

if you clear the Items, the itemlist is cleared correctly, but the last selected item caption stays displayed.

cmb.setItems(aEmptyCollection);
cmb.setValue(null);

I would expect the caption to be empty if an empty list is passed, or if a new list is passed the first should be selected.

@mattesnom
Copy link
Author

mattesnom commented Jun 21, 2017

ok i found out, that if you change

cmb.setItems(aEmptyCollection);
cmb.setValue(null);

to

cmb.setValue(null);
cmb.setItems(aEmptyCollection);

then it works as expected

@zanonmark
Copy link

I can confirm this bug in 8.0.6 (7.x was fine).

@zanonmark
Copy link

Duplication of #9047?

@mattesnom
Copy link
Author

mattesnom commented Jun 21, 2017 via email

@sebastianfilke
Copy link

I can confirm this bug. Is there any plan to fix this soon?

@simon-chromow
Copy link

Reproducible in 8.1.5

@stale
Copy link

stale bot commented Mar 19, 2018

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Mar 19, 2018
@tsuoanttila
Copy link
Contributor

Closed as duplicate of #9047

@tsuoanttila tsuoanttila added this to the Invalid milestone Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Stale Stale bot label
Projects
None yet
Development

No branches or pull requests

5 participants