Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OffsetDateTime and OffsetTime #2390

Open
cromoteca opened this issue May 6, 2024 · 1 comment
Open

Add support for OffsetDateTime and OffsetTime #2390

cromoteca opened this issue May 6, 2024 · 1 comment
Labels
enhancement New feature or request hilla Issues related to Hilla

Comments

@cromoteca
Copy link
Contributor

Describe your motivation

The generator supports the java.time.Local* date types, but not the Offset* counterparts. This is unfortunate, as they are the preferred classes for data transfer. From the java.time JavaDoc:

The offset-based date-time types OffsetTime and OffsetDateTime, are intended primarily for use with network protocols and database access.

Describe the solution you'd like

Those types are mapped to string instead of unknown.

Describe alternatives you've considered

There are easy workarounds like casting on the client or using a DTO that converts to String, but they are quite ugly.

Additional context

There's a related forum thread from @deniz-frick that illustrates the issue.

@cromoteca cromoteca added enhancement New feature or request hilla Issues related to Hilla labels May 6, 2024
@platosha
Copy link
Contributor

platosha commented May 7, 2024

Note that we need to update the CRUD components to support OffsetTime/OffsetDateTime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hilla Issues related to Hilla
Projects
None yet
Development

No branches or pull requests

2 participants