Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No logging output from 1.2.0.alpha1 #462

Closed
Artur- opened this issue Jul 4, 2022 · 1 comment · Fixed by #497
Closed

No logging output from 1.2.0.alpha1 #462

Artur- opened this issue Jul 4, 2022 · 1 comment · Fixed by #497
Assignees
Labels
bug Something isn't working hilla Issues related to Hilla

Comments

@Artur-
Copy link
Member

Artur- commented Jul 4, 2022

Description of the bug

There is no logging output when starting a 1.2.0.alpha1 application

Minimal reproducible example

vaadin init --pre --hilla project
cd project
mvn

Expected behavior

                       _              _   
 _ __   _ __   ___    (_)  ___   ___ | |_ 
| '_ \ | '__| / _ \   | | / _ \ / __|| __|
| |_) || |   | (_) |  | ||  __/| (__ | |_ 
| .__/ |_|    \___/  _/ | \___| \___| \__|
|_|                 |__/                  

2022-07-04 15:46:30.139  INFO 75922 --- [  restartedMain] com.example.application.Application      : Starting Application using Java 17.0.1 on ... with PID 75922 (.../target/classes started by artur in ...)
2022-07-04 15:46:30.139  INFO 75922 --- [  restartedMain] com.example.application.Application      : No active profile set, falling back to 1 default profile: "default"
2022-07-04 15:46:30.220  INFO 75922 --- [  restartedMain] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat initialized with port(s): 1000 (http)
2022-07-04 15:46:30.220  INFO 75922 --- [  restartedMain] o.apache.catalina.core.StandardService   : Starting service [Tomcat]
2022-07-04 15:46:30.220  INFO 75922 --- [  restartedMain] org.apache.catalina.core.StandardEngine  : Starting Servlet engine: [Apache Tomcat/9.0.64]
2022-07-04 15:46:30.226  INFO 75922 --- [  restartedMain] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring embedded WebApplicationContext
2022-07-04 15:46:30.226  INFO 75922 --- [  restartedMain] w.s.c.ServletWebServerApplicationContext : Root WebApplicationContext: initialization completed in 86 ms
2022-07-04 15:46:30.236  INFO 75922 --- [  restartedMain] c.v.f.s.VaadinServletContextInitializer  : Search for VaadinAppShell took 1 ms
2022-07-04 15:46:30.351  INFO 75922 --- [  restartedMain] c.v.f.s.VaadinServletContextInitializer  : Search for subclasses and classes with annotations took 104 ms
2022-07-04 15:46:30.352  WARN 75922 --- [  restartedMain] c.v.b.d.stats.DevModeUsageStatistics     : init should only be called once
2022-07-04 15:46:30.356  INFO 75922 --- [  restartedMain] c.v.b.d.startup.DevModeStartupListener   : Starting dev-mode updaters in ... folder.
2022-07-04 15:46:30.358  INFO 75922 --- [  restartedMain] c.v.f.s.f.s.FullDependenciesScanner      : Visited 6 classes. Took 1 ms.
Vaadin application has been deployed and started to the context path "/".
2022-07-04 15:46:30.384  INFO 75922 --- [onPool-worker-1] i.s.c.v3.ignore.CodegenIgnoreProcessor   : No .swagger-codegen-ignore file found.
2022-07-04 15:46:30.392  INFO 75922 --- [onPool-worker-1] io.swagger.codegen.v3.AbstractGenerator  : writing file .../frontend/generated/HelloWorldEndpoint.ts
2022-07-04 15:46:30.393  INFO 75922 --- [onPool-worker-1] dev.hilla.generator.ClientAPIGenerator   : writing file .../frontend/generated/endpoints.ts
2022-07-04 15:46:30.401  INFO 75922 --- [onPool-worker-1] c.v.f.s.frontend.TaskUpdatePackages      : Skipping `npm install` because the frontend packages are already installed in the folder '.../node_modules' and the hash in the file '.../node_modules/.vaadin/vaadin.json' is the same as in 'package.json'
2022-07-04 15:46:30.401  INFO 75922 --- [onPool-worker-1] c.v.f.s.frontend.TaskCopyFrontendFiles   : Copying frontend resources from jar files ...
2022-07-04 15:46:30.404  INFO 75922 --- [onPool-worker-1] c.v.f.s.frontend.TaskCopyFrontendFiles   : Visited 3 resources. Took 3 ms.
2022-07-04 15:46:30.409  INFO 75922 --- [onPool-worker-1] c.v.b.devserver.AbstractDevServerRunner  : Reusing Vite running at http://localhost:63052
2022-07-04 15:46:30.414  WARN 75922 --- [  restartedMain] o.s.b.d.a.OptionalLiveReloadServer       : Unable to start LiveReload server
2022-07-04 15:46:30.423  INFO 75922 --- [  restartedMain] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat started on port(s): 1000 (http) with context path ''
2022-07-04 15:46:30.425  INFO 75922 --- [  restartedMain] com.example.application.Application      : Started Application in 0.298 seconds (JVM running for 12.237)
2022-07-04 15:46:30.426  INFO 75922 --- [  restartedMain] .ConditionEvaluationDeltaLoggingListener : Condition evaluation unchanged
2022-07-04 15:46:30.917  INFO 75922 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : 
2022-07-04 15:46:30.917  INFO 75922 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : Found 0 errors. Watching for file changes.
2022-07-04 15:46:32.070  INFO 75922 --- [nio-1000-exec-1] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring DispatcherServlet 'dispatcherServlet'
2022-07-04 15:46:32.070  INFO 75922 --- [nio-1000-exec-1] o.s.web.servlet.DispatcherServlet        : Initializing Servlet 'dispatcherServlet'
2022-07-04 15:46:32.070  INFO 75922 --- [nio-1000-exec-1] o.s.web.servlet.DispatcherServlet        : Completed initialization in 0 ms

Actual behavior

                       _              _   
 _ __   _ __   ___    (_)  ___   ___ | |_ 
| '_ \ | '__| / _ \   | | / _ \ / __|| __|
| |_) || |   | (_) |  | ||  __/| (__ | |_ 
| .__/ |_|    \___/  _/ | \___| \___| \__|
|_|                 |__/                  

Vaadin application has been deployed and started to the context path "/".
15:45:07.895 [ForkJoinPool.commonPool-worker-1] INFO  i.s.c.v.i.CodegenIgnoreProcessor - No .swagger-codegen-ignore file found.
15:45:07.976 [ForkJoinPool.commonPool-worker-1] INFO  i.s.codegen.v3.AbstractGenerator - writing file /.../frontend/generated/HelloWorldEndpoint.ts

Most likely the same issue as vaadin/flow#11806

@Artur- Artur- added bug Something isn't working hilla Issues related to Hilla labels Jul 4, 2022
@cromoteca cromoteca self-assigned this Jul 4, 2022
@cromoteca
Copy link
Contributor

As pointed out in the related Flow issue, swagger-codegen-generators, starting from version 1.0.21, includes a logback.xml configuration file which imposes a default level of error for console logging. While they should probably fix that on their side, it is preferable not to downgrade to take advantage of present and future bug fixes.

We should override that default, but IMHO it is not a good idea to also impose a logging configuration ourselves. That should go in the generated application instead: adding a file identical to the one used by swagger-codegen-generators, but with info instead of error, is enough to restore the missing log lines.

A good default logging configuration should be discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants