New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compatible with Collaboration Kit #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to extract all the formatting changes to a separate PR, so we keep the relevant change on a clean commit.
kubernetes-kit-demo/src/main/java/com/vaadin/kubernetes/demo/generator/DataGenerator.java
Outdated
Show resolved
Hide resolved
kubernetes-kit-starter/src/main/java/com/vaadin/kubernetes/starter/SerializationProperties.java
Outdated
Show resolved
Hide resolved
I propose another little change related to private boolean matchesPrototype(String beanName, Object beanDefinition,
Class<?> fieldValueType) {
return appCtx.containsBean(beanName) && appCtx.isPrototype(beanName);
} In addition, as discussed with @MatthewVaadin, prototype beans may cause issues in deserialization: |
Description
As part of the work to allow Collaboration Kit to work with the Kubernetes Kit session serialization, it was found that K8s Kit has an issue when trying to determine if a bean has been defined for transient fields. If the class is just
Object
, Spring returns a prototype bean.Type of change