Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Polymer 2 and fix tests #24

Closed
wants to merge 2 commits into from
Closed

Update to Polymer 2 and fix tests #24

wants to merge 2 commits into from

Conversation

alvarezguille
Copy link
Member

@alvarezguille alvarezguille commented Feb 27, 2017 •
edited
Loading

This change is Reviewable

@rogozinds
Copy link
Contributor

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

vaadin-license-dialog.html, line 200 at r1 (raw file):

if(this.headers.hasOwnProperty(type)){
Try set default value for type instead.

Comments from Reviewable

@alvarezguille alvarezguille deleted the task/dash-35 branch February 27, 2017 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rogozinds rogozinds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alvarezguille @rogozinds