Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3 preview #53

Merged
merged 4 commits into from
Jun 20, 2018
Merged

P3 preview #53

merged 4 commits into from
Jun 20, 2018

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Jun 20, 2018

This change is Reviewable

manolo and others added 3 commits April 10, 2018 14:21
* Prepare for P3
* Use vanilla web component for license box
@manolo
Copy link
Member

manolo commented Jun 20, 2018

Review status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @tomivirkki)


vaadin-license-checker.html, line 162 at r4 (raw file):

    static get version() {
      return '2.0.1-pre.1';

should be without pre


Comments from Reviewable

@tomivirkki
Copy link
Member Author

Review status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @manolo)


vaadin-license-checker.html, line 162 at r4 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

should be without pre

Done.


Comments from Reviewable

@manolo
Copy link
Member

manolo commented Jun 20, 2018

Review status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @tomivirkki)


bower.json, line 21 at r5 (raw file):

    "web-component-tester": "^6.0.0",
    "iron-test-helpers": "PolymerElements/iron-test-helpers#^2.0.0",
    "vaadin-development-mode-detector": "vaadin/vaadin-development-mode-detector#^1.1.0-alpha2"

should be ^1.1.0 ?


Comments from Reviewable

@tomivirkki
Copy link
Member Author

Review status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @manolo)


bower.json, line 21 at r5 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

should be ^1.1.0 ?

Done.


Comments from Reviewable

@manolo
Copy link
Member

manolo commented Jun 20, 2018

:lgtm:


Reviewed 7 of 11 files at r1, 1 of 3 files at r2, 2 of 2 files at r4, 1 of 1 files at r5.
Review status: 10 of 11 files reviewed, all discussions resolved (waiting on @manolo)


Comments from Reviewable

@manolo
Copy link
Member

manolo commented Jun 20, 2018

Reviewed 1 of 1 files at r6.
Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

@manolo manolo merged commit 3a9789e into 2.0 Jun 20, 2018
@manolo manolo deleted the p3-preview branch June 20, 2018 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants