Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to generate npm-shrinkwrap.json #529

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Feb 5, 2019

Connected to #515

Note: both the generated package.json and npm-shrinkwrap.json must be copied, committed and published during the release process, I haven't covered that part (need to configure CI).

So, to get this finished, we need following steps:

1. create a separate repo DONE: https://github.com/vaadin/vaadin-shrinkwrap

Release process config to be updated:

  1. copy files to that repo
  2. commit and push
  3. run npm publish --access public in that repo

This change is Reviewable

@web-padawan web-padawan force-pushed the npm-shrinkwrap-generate branch 2 times, most recently from 8235a1f to c22d1a4 Compare February 5, 2019 09:01
Copy link
Contributor

@mehdi-vaadin mehdi-vaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mehdi-vaadin mehdi-vaadin merged commit cadad90 into master Feb 5, 2019
@mehdi-vaadin mehdi-vaadin deleted the npm-shrinkwrap-generate branch February 5, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants