-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add GridTreeColumn header and footer renderers #194
Conversation
9315bb1
to
68d9b2a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 98.85% 98.90% +0.04%
==========================================
Files 25 26 +1
Lines 175 183 +8
Branches 20 20
==========================================
+ Hits 173 181 +8
Misses 1 1
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 2.3, i have encountered the following issue. Can you take a look and pick it manually? |
Description
Unlike other custom column types,
GridTreeColumn
didn't supportheaderRenderer
andfooterRenderer
.This is misaligned with the corresponding web component where only
renderer
function is not supported.This PR adds missing APIs so it can be probably considered a bug fix (and therefore backported to 2.3)
Type of change