Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Conflict difference between assemble and build packages.json #850

Closed
LordTylus opened this issue Apr 20, 2023 · 1 comment
Closed

Comments

@LordTylus
Copy link

LordTylus commented Apr 20, 2023

Greetings,

I recently upgraded to Vaadin to version 23.3.10 and noticed a weird behavior which seems to be related to Vaadin Router.

Whenever I build my project using gradlew assemble Vaadin updates the entry for Router in my packages.json from 1.7.5 to 1.7.4.

However, if I start up my application from IntelliJ it reverts the changes back and uses 1.7.5 again. This is currently causing some issues with my build pipeline, as my versioning detects uncommitted changes in the workspace, which shouldn't be there.

after investigating the 1.7.5 Tag here I noticed that the package.json indeed lists the correct version number, however in router-meta.js Lists 1.7.4

Digging a bit deeper indicates, that the gradle assemble task calls prepareFrontend, and starting it up calls buildFrontend. Where the latter uses the expected version.

Could that be the source of my observations?

@Artur-
Copy link
Member

Artur- commented Apr 20, 2023

See vaadin/platform#4024

@Artur- Artur- closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants