Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@vaadin/router version inconsistency #4024

Closed
oflege opened this issue Apr 7, 2023 · 3 comments
Closed

@vaadin/router version inconsistency #4024

oflege opened this issue Apr 7, 2023 · 3 comments

Comments

@oflege
Copy link

oflege commented Apr 7, 2023

Describe the bug

flow-server:23.3.7 has this in com/vaadin/flow/server/frontend/dependencies/default/package.json
"@vaadin/router": "1.7.4"

whereas vaadin-core:23.3.11 has this in META-INF/vaadin-core-versions.json
"vaadin-router": { "jsVersion": "1.7.5",

gradle vaadinPrepareFrontend uses the former and puts version "1.7.4" into our project's package.json whereas gradle vaadinBuildFrontend uses the latter and changes the version to "1.7.5"

Expected-behavior

version of @vaadin/router is consistent

Reproduction

see bug description

System Info

vaadin platform release 23.3.11

@oflege oflege added the bug label Apr 7, 2023
@mcollovati mcollovati added this to Needs triage in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) via automation Apr 7, 2023
@SonReimer
Copy link

SonReimer commented Apr 18, 2023

This leads to newly written package.json and pnpm-lock.yaml whenever application is started in ide,
which slows done startup, because frontend is compiled every time
due to variable 'added' is set to '1' in TaskUpdatePackages.updatePackageJsonDependencies for vaadin/router

@SonReimer
Copy link

SonReimer commented Apr 18, 2023

This is awesome.
I thought the files should only change once, when starting application after vaadin:prepare-frontend,
but not on repeated starts of the application.

@ZheSun88
Copy link
Contributor

this issue should be fixed in Vaadin 23.3.12, which has been released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants