Vaadin-Spreadsheet issue #665 #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix cell width calculation to account for merged cells when deciding whether to display hashes instead of the value
|
Looks like the test failure was just a difference between PhantomJS on my Windows system and the test hub Linux config. Vaadin folks will need to verify and add/update correct master screenshots. The "failed" one there shows the proper cell content display (as opposed to loading the test file in the current release version of Spreadsheet). |
tulioag
approved these changes
Feb 28, 2019
tulioag
approved these changes
Feb 28, 2019
There was a problem hiding this comment.
Reviewed 2 of 5 files at r1, 3 of 3 files at r2, 3 of 3 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
manolo
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Apr 27, 2022
vaadin/spreadsheet#696 fix cell width calculation to account for merged cells when deciding whether to display hashes instead of the value Fixes: vaadin/spreadsheet#665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cell width calculation to account for merged cells when deciding whether to display hashes instead of the value.
I've been running a workaround for a year or so, this is to finally propose a fix with unit test. Test passes in PhantomJS. Upload the test workbook to the Vaadin Demo app to see the problem - cell A2 displays as "##" in the demo, when the cell is merged and has room to display the full numeric content 123456.
This change is