Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running in headless mode using -Dcom.vaadin.testbench.Parameters.headless=true #1234

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Nov 14, 2019

This change is Reviewable

@Artur- Artur- changed the title Allow running Chrome in headless mode using -Dcom.vaadin.testbench.Parameters.chrome.headless=true Allow running in headless mode using -Dcom.vaadin.testbench.Parameters.headless=true Nov 14, 2019
@Artur- Artur- force-pushed the headless-chrome branch 2 times, most recently from ebe8747 to 53ad9d2 Compare November 14, 2019 14:07
Copy link
Member

@alvarezguille alvarezguille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @Artur-)


vaadin-testbench-core/src/main/java/com/vaadin/testbench/Parameters.java, line 512 at r1 (raw file):

Sets whether to run browsers in headless mode when possible.

Should specify that it's only going to be used with Chrome and Firefox when using local webdriver

Copy link
Member Author

@Artur- Artur- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @alvarezguille)


vaadin-testbench-core/src/main/java/com/vaadin/testbench/Parameters.java, line 512 at r1 (raw file):

Previously, alvarezguille (Guille) wrote…
Sets whether to run browsers in headless mode when possible.

Should specify that it's only going to be used with Chrome and Firefox when using local webdriver

Done.

Copy link
Member

@alvarezguille alvarezguille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@alvarezguille alvarezguille merged commit d9f1387 into master Nov 25, 2019
@alvarezguille alvarezguille deleted the headless-chrome branch November 25, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants