Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not wait if no Flow connectors found #1296

Merged
merged 6 commits into from
Oct 25, 2021
Merged

fix: Do not wait if no Flow connectors found #1296

merged 6 commits into from
Oct 25, 2021

Conversation

mshabarov
Copy link
Contributor

@mshabarov mshabarov commented Aug 31, 2021 •
edited

Description

Fixes #1294

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@mshabarov mshabarov added this to Iteration Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) via automation Sep 1, 2021
@mshabarov mshabarov marked this pull request as ready for review September 1, 2021 08:18
@mshabarov
Copy link
Contributor Author

@Artur- could you please review when appropriate?

@mshabarov mshabarov requested a review from Artur- October 18, 2021 10:36
@mshabarov mshabarov requested a review from pleku October 25, 2021 11:19
@pleku pleku dismissed Artur-’s stale review October 25, 2021 12:08

Requested changes have been applied

@pleku pleku merged commit 37c9c5d into master Oct 25, 2021
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Oct 25, 2021
@pleku pleku deleted the fix/wait-for-vaadin-1294 branch October 25, 2021 12:08
@mshabarov mshabarov mentioned this pull request Nov 8, 2021
Closed
@ZheSun88 ZheSun88 mentioned this pull request Nov 9, 2021
Closed
Artur- added a commit that referenced this pull request Nov 12, 2021
@Artur-
fix: Wait for dev mode server to finish (#1304)
b90d75c 
Fixes a regression introduced in #1296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleku pleku pleku approved these changes

@Artur- Artur- Awaiting requested review from Artur-

Assignees
No one assigned
Labels
None yet
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't keep waiting if Flow clients are not defined
4 participants
@mshabarov @CLAassistant @Artur- @pleku