Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slf4j like the rest of the platform #1313

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Use slf4j like the rest of the platform #1313

merged 3 commits into from
Feb 7, 2022

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Feb 4, 2022

No description provided.

@alvarezguille
Copy link
Member

@Artur- should testbench-core now have an explicit dependency to slf4j?

@Artur-
Copy link
Member Author

Artur- commented Feb 5, 2022

yes

@Artur- Artur- enabled auto-merge (squash) February 7, 2022 11:22
@Artur- Artur- merged commit 06dcf3d into master Feb 7, 2022
@Artur- Artur- deleted the slf4j branch February 7, 2022 16:02
alvarezguille pushed a commit that referenced this pull request Oct 7, 2022
@Artur- @alvarezguille
chore: Use slf4j like the rest of the platform (#1313)
2630192
@alvarezguille alvarezguille mentioned this pull request Oct 7, 2022
Merged
alvarezguille added a commit that referenced this pull request Oct 10, 2022
@alvarezguille
chore: Use slf4j like the rest of the platform (#1533)
819057c 
Cherry picks the following log related changes:

* a261ab8 - chore: Log using logger instead of system.out
* b28709d - fix: Log using logger instead of system.err (#1505)
* 2630192 - chore: Use slf4j like the rest of the platform (#1313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezguille alvarezguille alvarezguille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Artur- @alvarezguille