Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 8.0.0.beta1 #858

Merged
merged 3 commits into from
Dec 20, 2016
Merged

Update to 8.0.0.beta1 #858

merged 3 commits into from
Dec 20, 2016

Conversation

alvarezguille
Copy link
Member

@alvarezguille alvarezguille commented Dec 19, 2016

This change is Reviewable

@Artur-
Copy link
Member

Artur- commented Dec 20, 2016

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


testbench-integration-tests/src/main/java/com/vaadin/testUI/CheckBoxGroupSetValue.java, line 20 at r1 (raw file):

        options.add("item2");
        options.add("item3");
        group.setDataProvider(new ListDataProvider<>(options));

Could use group.setItems(options) here and in other places


Comments from Reviewable

@rogozinds
Copy link
Contributor

:lgtm:


Reviewed 6 of 8 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


testbench-integration-tests/src/main/java/com/vaadin/testUI/CheckBoxGroupSetValue.java, line 20 at r1 (raw file):

Previously, Artur- (Artur) wrote…

Could use group.setItems(options) here and in other places

Fixed


Comments from Reviewable

@rogozinds
Copy link
Contributor

Reviewed 1 of 8 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@rogozinds rogozinds merged commit 42a819c into master Dec 20, 2016
@rogozinds rogozinds deleted the task/8.0.0.beta1 branch December 20, 2016 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants