Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Framework API, which was moved to the Framework project #862

Merged
merged 2 commits into from
Jan 10, 2017
Merged

Remove Framework API, which was moved to the Framework project #862

merged 2 commits into from
Jan 10, 2017

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Dec 22, 2016 •
edited

This change is Reviewable

@rogozinds
Copy link
Contributor

:lgtm:

Reviewed 78 of 78 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@rogozinds
Copy link
Contributor

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@rogozinds @Artur-
Remove testbench-api from assembly.xml.
51b2b26 
There is no need to have maven structure duplicated in
vaadin-directory zip file. That's a legacy, that is not needed
anymore.
@rogozinds
Copy link
Contributor

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@rogozinds rogozinds merged commit 950e04a into master Jan 10, 2017
@rogozinds rogozinds deleted the remove-fw-api branch January 10, 2017 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Artur- @rogozinds