Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about FF Actions API to docs, closes #TB-86 #863

Merged
merged 1 commit into from
Jan 9, 2017

Conversation

rogozinds
Copy link
Contributor

@rogozinds rogozinds commented Dec 27, 2016

This change is Reviewable

@rogozinds rogozinds assigned rogozinds and Artur- and unassigned Artur- and rogozinds Dec 27, 2016
@Artur-
Copy link
Member

Artur- commented Dec 27, 2016

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.


documentation/testbench-quickstart.asciidoc, line 35 at r1 (raw file):

[NOTE]
Latest Firefox (version 50.1.0) does not support link:https://github.com/mozilla/geckodriver/issues/159[actions API].

The problem is not in Firefox but in Geckodriver, so maybe rephrase a bit e.g.
"Geckodriver used for the latest Firefox versions (48 and newer) does not support ..."


documentation/testbench-quickstart.asciidoc, line 36 at r1 (raw file):

can be fixed
"has been fixed", otherwise it sounds like we are going to fix it


Comments from Reviewable

@rogozinds
Copy link
Contributor Author

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.


documentation/testbench-quickstart.asciidoc, line 35 at r1 (raw file):

Previously, Artur- (Artur) wrote…

The problem is not in Firefox but in Geckodriver, so maybe rephrase a bit e.g.
"Geckodriver used for the latest Firefox versions (48 and newer) does not support ..."

Done.


documentation/testbench-quickstart.asciidoc, line 36 at r1 (raw file):

Previously, Artur- (Artur) wrote…

can be fixed
"has been fixed", otherwise it sounds like we are going to fix it

Done.


Comments from Reviewable

@Artur-
Copy link
Member

Artur- commented Dec 27, 2016

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.


documentation/testbench-quickstart.asciidoc, line 36 at r1 (raw file):

Previously, rogozinds (rogozinds) wrote…

Done.

"has been fixed"


Comments from Reviewable

@rogozinds
Copy link
Contributor Author

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.


documentation/testbench-quickstart.asciidoc, line 36 at r1 (raw file):

Previously, Artur- (Artur) wrote…

"has been fixed"

Done.


Comments from Reviewable

@Artur-
Copy link
Member

Artur- commented Dec 27, 2016

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@rogozinds rogozinds merged commit 0fa0a65 into master Jan 9, 2017
@rogozinds rogozinds deleted the fix/docs_ff45 branch January 9, 2017 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants