-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change showTooltip to wait for tooltip to appear #877
Conversation
Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions. testbench-integration-tests/src/test/java/com/vaadin/tests/elements/TestbenchElementTooltipIT.java, line 18 at r1 (raw file):
Rename testbench-integration-tests/src/test/java/com/vaadin/tests/elements/TestbenchElementTooltipIT.java, line 28 at r1 (raw file):
There should be another test when you
vaadin-testbench-core/src/main/java/com/vaadin/testbench/TestBenchElement.java, line 173 at r1 (raw file):
Is 3s always enough? Comments from Reviewable |
Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions. testbench-integration-tests/src/test/java/com/vaadin/tests/elements/TestbenchElementTooltipIT.java, line 18 at r1 (raw file): Previously, Artur- (Artur) wrote…
Done. testbench-integration-tests/src/test/java/com/vaadin/tests/elements/TestbenchElementTooltipIT.java, line 28 at r1 (raw file): Previously, Artur- (Artur) wrote…
Done. vaadin-testbench-core/src/main/java/com/vaadin/testbench/TestBenchElement.java, line 173 at r1 (raw file): Previously, Artur- (Artur) wrote…
it was 0.75 before Comments from Reviewable |
Don't merge, does not work in IE11 Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
Turned out that the new tests won't pass with previous code neither. Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
dbc631f
to
bee79db
Compare
what was the decision here? does it require a special fix for IE? |
No reaction in half a year, please reopen if this is still relevant |
This change is