Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change showTooltip to wait for tooltip to appear #877

Closed
wants to merge 1 commit into from

Conversation

rogozinds
Copy link
Contributor

@rogozinds rogozinds commented Mar 16, 2017

This change is Reviewable

@Artur-
Copy link
Member

Artur- commented Mar 16, 2017

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.


testbench-integration-tests/src/test/java/com/vaadin/tests/elements/TestbenchElementTooltipIT.java, line 18 at r1 (raw file):

    @Test
    public void elementCompareScreen() throws Exception {

Rename


testbench-integration-tests/src/test/java/com/vaadin/tests/elements/TestbenchElementTooltipIT.java, line 28 at r1 (raw file):

        Assert.assertEquals("Tooltip",tooltipText);
    }

There should be another test when you

  1. Show tooltip for component 1
  2. Show tooltip for component 2
  3. Verify that tooltip for component 2 and not component 1 is shown

vaadin-testbench-core/src/main/java/com/vaadin/testbench/TestBenchElement.java, line 173 at r1 (raw file):

            .moveToElement(actualElement).perform();

        new WebDriverWait(getDriver(), 3)

Is 3s always enough?


Comments from Reviewable

@rogozinds
Copy link
Contributor Author

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.


testbench-integration-tests/src/test/java/com/vaadin/tests/elements/TestbenchElementTooltipIT.java, line 18 at r1 (raw file):

Previously, Artur- (Artur) wrote…

Rename

Done.


testbench-integration-tests/src/test/java/com/vaadin/tests/elements/TestbenchElementTooltipIT.java, line 28 at r1 (raw file):

Previously, Artur- (Artur) wrote…

There should be another test when you

  1. Show tooltip for component 1
  2. Show tooltip for component 2
  3. Verify that tooltip for component 2 and not component 1 is shown

Done.


vaadin-testbench-core/src/main/java/com/vaadin/testbench/TestBenchElement.java, line 173 at r1 (raw file):

Previously, Artur- (Artur) wrote…

Is 3s always enough?

it was 0.75 before


Comments from Reviewable

@rogozinds
Copy link
Contributor Author

Don't merge, does not work in IE11


Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@rogozinds
Copy link
Contributor Author

Turned out that the new tests won't pass with previous code neither.


Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@rogozinds rogozinds force-pushed the tooltipfix branch 2 times, most recently from dbc631f to bee79db Compare March 22, 2017 11:20
@alvarezguille
Copy link
Member

what was the decision here? does it require a special fix for IE?

@Artur-
Copy link
Member

Artur- commented Oct 6, 2017

No reaction in half a year, please reopen if this is still relevant

@Artur- Artur- closed this Oct 6, 2017
@alvarezguille alvarezguille deleted the tooltipfix branch February 26, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants